Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP_HAL_ChibiOS: add new target Stellar H7V2 #28926

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

cvetaevvitaliy
Copy link
Contributor

add Stellar H7V2 target

@Hwurzburg
Copy link
Collaborator

Needs full readme with images and pinouts...see other recent hwdefs....should break out board id into separate PR that can be merged before this gets a review in order to reserve the board id...also use the text board name instead of number in the hwdefs

@cvetaevvitaliy
Copy link
Contributor Author

Needs full readme with images and pinouts...see other recent hwdefs....should break out board id into separate PR that can be merged before this gets a review in order to reserve the board id...also use the text board name instead of number in the hwdefs

Done

#28929

@cvetaevvitaliy cvetaevvitaliy changed the title add Stellar H7V2 target AP_HAL_ChibiOS: add new target Stellar H7V2 Dec 22, 2024
Copy link
Collaborator

@andyp1per andyp1per left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commits need to be squashed per subsystem and labeled according to our coding standards. Please see https://ardupilot.org/dev/docs/submitting-patches-back-to-master.html

Copy link
Collaborator

@Hwurzburg Hwurzburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you will also need to squash the commits into one for the Tools library titled
Tools:add StellarH7V2

and one for the hwdef library titled
HWDEF: add StellarH7V2

Please make similar changes as from this review to PR#28925 StellarF4 and then I will review it also

@cvetaevvitaliy
Copy link
Contributor Author

cvetaevvitaliy commented Jan 9, 2025 via email

@cvetaevvitaliy
Copy link
Contributor Author

@Hwurzburg @andyp1per could you look at the changes in open issues ?
Thanks

Copy link
Collaborator

@andyp1per andyp1per left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Henry's changes need to be addressed and the commit messages changed

@cvetaevvitaliy cvetaevvitaliy force-pushed the stellar-h7v2 branch 4 times, most recently from c6687ea to 4470826 Compare January 16, 2025 16:03
@marchuks marchuks force-pushed the stellar-h7v2 branch 2 times, most recently from a41f926 to cbfbad3 Compare February 26, 2025 22:32
@marchuks
Copy link

Hi,

I’ll be taking responsibility for this PR as well as any related ones regarding Stellar boards. I’ve made an effort to consolidate feedback and comments from the associated PRs, but please feel free to point out if I’ve missed anything or if there are any additional concerns that need to be addressed.

Looking forward to collaborating with everyone to get this merged. Let me know if you have any questions or if further clarification is needed on any part of the changes.

Copy link
Collaborator

@Hwurzburg Hwurzburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking very good...a couple of minor things
and a "merge" commit got added...should only have a Tools and a AP_HAL_ChibiOS or hwdef commit (either title works)

* PPM is not supported.
* SBUS/DSM/SRXL connects to the RX4 pin.
* FPort requires connection to TX4 and RX4 via a bi-directional inverter. See :ref:`common-FPort-receivers`.
* CRSF also requires a TX4 connection, in addition to RX6, and automatically provides telemetry.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* CRSF also requires a TX4 connection, in addition to RX6, and automatically provides telemetry.
* CRSF also requires a TX4 connection, in addition to RX4, and automatically provides telemetry.

The default RC input is configured on the UART4 RX4 input and can be used for all ArduPilot supported unidirectional receiver protocols.
* PPM is not supported.
* SBUS/DSM/SRXL connects to the RX4 pin.
* FPort requires connection to TX4 and RX4 via a bi-directional inverter. See :ref:`common-FPort-receivers`.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* FPort requires connection to TX4 and RX4 via a bi-directional inverter. See :ref:`common-FPort-receivers`.
* FPort requires connection to TX4 and :ref:`SERIAL4_OPTIONS<SERIAL4_OPTIONS>` set to "7". See :ref:`common-FPort-receivers`.

The default battery parameters are:
* :ref:`BATT_MONITOR<BATT_MONITOR>` = 4
* :ref:`BATT_VOLT_PIN<BATT_VOLT_PIN__AP_BattMonitor_Analog>` = 10
* :ref:`BATT_CURR_PIN<BATT_CURR_PIN__AP_BattMonitor_Analog>` = 11
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* :ref:`BATT_CURR_PIN<BATT_CURR_PIN__AP_BattMonitor_Analog>` = 11
* :ref:`BATT_CURR_PIN<BATT_CURR_PIN__AP_BattMonitor_Analog>` = 11 (CURR pin)

* :ref:`BATT_CURR_PIN<BATT_CURR_PIN__AP_BattMonitor_Analog>` = 11
* :ref:`BATT_VOLT_MULT<BATT_VOLT_MULT__AP_BattMonitor_Analog>` = 11
* :ref:`BATT_AMP_PERVLT<BATT_AMP_PERVLT__AP_BattMonitor_Analog>` = 10
* :ref:`BATT2_CURR_PIN<BATT2_CURR_PIN__AP_BattMonitor_Analog>` = 7
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* :ref:`BATT2_CURR_PIN<BATT2_CURR_PIN__AP_BattMonitor_Analog>` = 7
* :ref:`BATT2_CURR_PIN<BATT2_CURR_PIN__AP_BattMonitor_Analog>` = 7 (ADC2 pin)

# USART1
PA10 USART1_RX USART1
PA9 USART1_TX USART1
define DEFAULT_SERIAL1_PROTOCOL SerialProtocol_MAVLink2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove, default already

# USART2
PD5 USART2_TX USART2
PD6 USART2_RX USART2
define DEFAULT_SERIAL1_PROTOCOL SerialProtocol_MAVLink2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove, default already

PB1 TIM3_CH4 TIM3 PWM(2) GPIO(51) # M2
PA0 TIM5_CH1 TIM5 PWM(3) GPIO(52) BIDIR # M3
PA1 TIM5_CH2 TIM5 PWM(4) GPIO(53) # M4
PA2 TIM5_CH3 TIM5 PWM(5) GPIO(54) # M5
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
PA2 TIM5_CH3 TIM5 PWM(5) GPIO(54) # M5
PA2 TIM5_CH3 TIM5 PWM(5) GPIO(54) BIDIR # M5

@marchuks
Copy link

marchuks commented Mar 3, 2025

Thanks for your suggestions. I’ve applied all of them.
It appears GitHub automatically added the merge commit, since I don’t see it locally. I’ll keep that in mind for next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants