-
Notifications
You must be signed in to change notification settings - Fork 18.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AP_HAL_ChibiOS: add new target Stellar H7V2 #28926
base: master
Are you sure you want to change the base?
Conversation
Needs full readme with images and pinouts...see other recent hwdefs....should break out board id into separate PR that can be merged before this gets a review in order to reserve the board id...also use the text board name instead of number in the hwdefs |
Done |
b37729f
to
9fc3261
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commits need to be squashed per subsystem and labeled according to our coding standards. Please see https://ardupilot.org/dev/docs/submitting-patches-back-to-master.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you will also need to squash the commits into one for the Tools library titled
Tools:add StellarH7V2
and one for the hwdef library titled
HWDEF: add StellarH7V2
Please make similar changes as from this review to PR#28925 StellarF4 and then I will review it also
No problem.
New Year's holidays are over, back to work.
чт, 9 січ. 2025 р. о 18:13 Henry Wurzburg ***@***.***> пише:
… ***@***.**** requested changes on this pull request.
you will also need to squash the commits into one for the Tools library
titled
Tools:add StellarH7V2
and one for the hwdef library titled
HWDEF: add StellarH7V2
------------------------------
In libraries/AP_HAL_ChibiOS/hwdef/StellarH7V2/Readme.md
<#28926 (comment)>
:
> @@ -0,0 +1,94 @@
+# StellarH7V2 Flight Controller
+
+https://stingbee.com.ua/flight_controllers/stellarh7v2
+
+
+## Features
+ Processor
+ STM32H743VIH6 480 MHz, 2MB flash
+ Sensors
+ ICM-42688p Acc/Gyro with external clock feature
+ DPS310/BMP280 barometer
+ AT7456E OSD
+ SD Card
+ W25N02G/1G dataflash
unless this will be on the autopilot when we merge this, remove this line
------------------------------
In libraries/AP_HAL_ChibiOS/hwdef/StellarH7V2/Readme.md
<#28926 (comment)>
:
> +# StellarH7V2 Flight Controller
+
+https://stingbee.com.ua/flight_controllers/stellarh7v2
+
+
+## Features
+ Processor
+ STM32H743VIH6 480 MHz, 2MB flash
+ Sensors
+ ICM-42688p Acc/Gyro with external clock feature
+ DPS310/BMP280 barometer
+ AT7456E OSD
+ SD Card
+ W25N02G/1G dataflash
+ Power
+ 8S Lipo input voltage with voltage monitoring
2S-8S?
------------------------------
In libraries/AP_HAL_ChibiOS/hwdef/StellarH7V2/Readme.md
<#28926 (comment)>
:
> +
+## Features
+ Processor
+ STM32H743VIH6 480 MHz, 2MB flash
+ Sensors
+ ICM-42688p Acc/Gyro with external clock feature
+ DPS310/BMP280 barometer
+ AT7456E OSD
+ SD Card
+ W25N02G/1G dataflash
+ Power
+ 8S Lipo input voltage with voltage monitoring
+ 12V, 3A BEC for powering Video Transmitter
+ 5V, 2A BEC for internal and peripherals
+ Interfaces
+ 10x PWM outputs DShot capable
I see only 8 outputs on the board, what am I missing?
------------------------------
In libraries/AP_HAL_ChibiOS/hwdef/StellarH7V2/Readme.md
<#28926 (comment)>
:
> +
+## Features
+ Processor
+ STM32H743VIH6 480 MHz, 2MB flash
+ Sensors
+ ICM-42688p Acc/Gyro with external clock feature
+ DPS310/BMP280 barometer
+ AT7456E OSD
+ SD Card
+ W25N02G/1G dataflash
+ Power
+ 8S Lipo input voltage with voltage monitoring
+ 12V, 3A BEC for powering Video Transmitter
+ 5V, 2A BEC for internal and peripherals
+ Interfaces
+ 10x PWM outputs DShot capable
⬇️ Suggested change
- 10x PWM outputs DShot capable
+ 10x PWM outputs DShot capable, 4 outputs BDShot capable
------------------------------
In libraries/AP_HAL_ChibiOS/hwdef/StellarH7V2/Readme.md
<#28926 (comment)>
:
> + ICM-42688p Acc/Gyro with external clock feature
+ DPS310/BMP280 barometer
+ AT7456E OSD
+ SD Card
+ W25N02G/1G dataflash
+ Power
+ 8S Lipo input voltage with voltage monitoring
+ 12V, 3A BEC for powering Video Transmitter
+ 5V, 2A BEC for internal and peripherals
+ Interfaces
+ 10x PWM outputs DShot capable
+ 7x UARTs
+ 1x CAN
+ 1x I2C
+ 3x ADC
+ SD card and 128/256MB NAND for logging
⬇️ Suggested change
- SD card and 128/256MB NAND for logging
+ micro-SD card interface
------------------------------
In libraries/AP_HAL_ChibiOS/hwdef/StellarH7V2/Readme.md
<#28926 (comment)>
:
> + USB-C port
+ LED
+ Red, 3.3V power indicator
+ Blue and Green, FC status
+ Size
+ 41 x 41mm PCB with 30.5mm M3 mounting
+
+
+## Overview
+
+
+
+
+
+## Wiring Diagram
+
will this be provided?
------------------------------
In libraries/AP_HAL_ChibiOS/hwdef/StellarH7V2/Readme.md
<#28926 (comment)>
:
> + 41 x 41mm PCB with 30.5mm M3 mounting
+
+
+## Overview
+
+
+
+
+
+## Wiring Diagram
+
+
+## UART Mapping
+
+The UARTs are marked Rx* and Tx* in the above pinouts. The Rx* pin is the
+receive pin for UART*. The Tx* pin is the transmit pin for UART*.
⬇️ Suggested change
-receive pin for UART*. The Tx* pin is the transmit pin for UART*.
+receive pin for UART*. The Tx* pin is the transmit pin for UART*. All UARTS are DMA capable.
------------------------------
In libraries/AP_HAL_ChibiOS/hwdef/StellarH7V2/Readme.md
<#28926 (comment)>
:
> +## Overview
+
+
+
+
+
+## Wiring Diagram
+
+
+## UART Mapping
+
+The UARTs are marked Rx* and Tx* in the above pinouts. The Rx* pin is the
+receive pin for UART*. The Tx* pin is the transmit pin for UART*.
+
+ - SERIAL0 -> USB
+ - SERIAL1 -> USART1 (User)
Why not use the default protocols for UART1 and UART2 of MAVLink2??
------------------------------
In libraries/AP_HAL_ChibiOS/hwdef/StellarH7V2/Readme.md
<#28926 (comment)>
:
> +
+
+## Wiring Diagram
+
+
+## UART Mapping
+
+The UARTs are marked Rx* and Tx* in the above pinouts. The Rx* pin is the
+receive pin for UART*. The Tx* pin is the transmit pin for UART*.
+
+ - SERIAL0 -> USB
+ - SERIAL1 -> USART1 (User)
+ - SERIAL2 -> USART2 (User)
+ - SERIAL3 -> USART3 (User)
+ - SERIAL4 -> UART4 (Serial RC input)
+ - SERIAL6 -> USART6 (User)
⬇️ Suggested change
- - SERIAL6 -> USART6 (User)
+ - SERIAL5-> USART6 (GPS)
------------------------------
In libraries/AP_HAL_ChibiOS/hwdef/StellarH7V2/Readme.md
<#28926 (comment)>
:
> +
+## Wiring Diagram
+
+
+## UART Mapping
+
+The UARTs are marked Rx* and Tx* in the above pinouts. The Rx* pin is the
+receive pin for UART*. The Tx* pin is the transmit pin for UART*.
+
+ - SERIAL0 -> USB
+ - SERIAL1 -> USART1 (User)
+ - SERIAL2 -> USART2 (User)
+ - SERIAL3 -> USART3 (User)
+ - SERIAL4 -> UART4 (Serial RC input)
+ - SERIAL6 -> USART6 (User)
+ - SERIAL7 -> USART6 (User)
⬇️ Suggested change
- - SERIAL7 -> USART6 (User)
+ - SERIAL6 -> USART7 (DisplayPort)
------------------------------
In libraries/AP_HAL_ChibiOS/hwdef/StellarH7V2/Readme.md
<#28926 (comment)>
:
> +## Wiring Diagram
+
+
+## UART Mapping
+
+The UARTs are marked Rx* and Tx* in the above pinouts. The Rx* pin is the
+receive pin for UART*. The Tx* pin is the transmit pin for UART*.
+
+ - SERIAL0 -> USB
+ - SERIAL1 -> USART1 (User)
+ - SERIAL2 -> USART2 (User)
+ - SERIAL3 -> USART3 (User)
+ - SERIAL4 -> UART4 (Serial RC input)
+ - SERIAL6 -> USART6 (User)
+ - SERIAL7 -> USART6 (User)
+ - SERIAL8 -> USART6 (User)
⬇️ Suggested change
- - SERIAL8 -> USART6 (User)
+ - SERIAL7 -> USART8 (RX pin only, ESC Telemetry)
------------------------------
In libraries/AP_HAL_ChibiOS/hwdef/StellarH7V2/Readme.md
<#28926 (comment)>
:
> +The UARTs are marked Rx* and Tx* in the above pinouts. The Rx* pin is the
+receive pin for UART*. The Tx* pin is the transmit pin for UART*.
+
+ - SERIAL0 -> USB
+ - SERIAL1 -> USART1 (User)
+ - SERIAL2 -> USART2 (User)
+ - SERIAL3 -> USART3 (User)
+ - SERIAL4 -> UART4 (Serial RC input)
+ - SERIAL6 -> USART6 (User)
+ - SERIAL7 -> USART6 (User)
+ - SERIAL8 -> USART6 (User)
+
+## CAN and I2C
+
+StellarH7V2 supports 1x CAN bus and 1x I2C bus
+multiple CAN peripherals can be connected to one CAN bus in parallel. similarly for I2C bus.
"multiple CAN peripherals" comment line not necessary
------------------------------
In libraries/AP_HAL_ChibiOS/hwdef/StellarH7V2/Readme.md
<#28926 (comment)>
:
> + - SERIAL1 -> USART1 (User)
+ - SERIAL2 -> USART2 (User)
+ - SERIAL3 -> USART3 (User)
+ - SERIAL4 -> UART4 (Serial RC input)
+ - SERIAL6 -> USART6 (User)
+ - SERIAL7 -> USART6 (User)
+ - SERIAL8 -> USART6 (User)
+
+## CAN and I2C
+
+StellarH7V2 supports 1x CAN bus and 1x I2C bus
+multiple CAN peripherals can be connected to one CAN bus in parallel. similarly for I2C bus.
+
+## RC Input
+
+RC input is configured on the UART4(SERIAL4). It supports all serial RC protocols. SERIAL2_PROTOCOL=23 by default.
⬇️ Suggested change
-RC input is configured on the UART4(SERIAL4). It supports all serial RC protocols. SERIAL2_PROTOCOL=23 by default.
+The default RC input is configured on the UART4 RX4 input and can be used for all ArduPilot supported unidirectional receiver protocols.
+
+* PPM is not supported.
+* SBUS/DSM/SRXL connects to the RX4 pin.
+* FPort requires connection to TX4 and RX4 via a bi-directional inverter. See :ref:`common-FPort-receivers`.
+* CRSF also requires a TX4 connection, in addition to RX6, and automatically provides telemetry.
+* SRXL2 requires a connection to TX4 and automatically provides telemetry. Set :ref:`SERIAL4_OPTIONS<SERIAL4_OPTIONS>` to “4”.
------------------------------
In libraries/AP_HAL_ChibiOS/hwdef/StellarH7V2/Readme.md
<#28926 (comment)>
:
> + - SERIAL7 -> USART6 (User)
+ - SERIAL8 -> USART6 (User)
+
+## CAN and I2C
+
+StellarH7V2 supports 1x CAN bus and 1x I2C bus
+multiple CAN peripherals can be connected to one CAN bus in parallel. similarly for I2C bus.
+
+## RC Input
+
+RC input is configured on the UART4(SERIAL4). It supports all serial RC protocols. SERIAL2_PROTOCOL=23 by default.
+
+
+## OSD Support
+
+StellarH7V2 supports using its internal OSD using OSD_TYPE 1 (MAX7456 driver). External OSD support such as DJI or DisplayPort is supported using any spare UART. See :ref:`common-msp-osd-overview-4.2` for more info.
⬇️ Suggested change
-StellarH7V2 supports using its internal OSD using OSD_TYPE 1 (MAX7456 driver). External OSD support such as DJI or DisplayPort is supported using any spare UART. See :ref:`common-msp-osd-overview-4.2` for more info.
+StellarH7V2 supports using its internal OSD using OSD_TYPE 1 (MAX7456 driver). Simulatenous DisplayPort OSD operation is preconfigured on SERIAL 6 but requires OSD_TYPE2 = 5. See :ref:`common-msp-osd-overview-4.2` for more info.
------------------------------
In libraries/AP_HAL_ChibiOS/hwdef/StellarH7V2/Readme.md
<#28926 (comment)>
:
> +StellarH7V2 supports 1x CAN bus and 1x I2C bus
+multiple CAN peripherals can be connected to one CAN bus in parallel. similarly for I2C bus.
+
+## RC Input
+
+RC input is configured on the UART4(SERIAL4). It supports all serial RC protocols. SERIAL2_PROTOCOL=23 by default.
+
+
+## OSD Support
+
+StellarH7V2 supports using its internal OSD using OSD_TYPE 1 (MAX7456 driver). External OSD support such as DJI or DisplayPort is supported using any spare UART. See :ref:`common-msp-osd-overview-4.2` for more info.
+
+## PWM Output
+
+StellarH7V2 supports up to 10 PWM outputs. All outputs support DShot.
+
⬇️ Suggested change
-
+All the channels support DShot. Channels 1-4 support bi-directional DShot. PWM outputs are grouped and every group must use the same output protocol:
+
+* 1, 2,are Group 1;
+* 3 - 6 are Group 2;
+* 7 - 9 are Group 3;
------------------------------
In libraries/AP_HAL_ChibiOS/hwdef/StellarH7V2/Readme.md
<#28926 (comment)>
:
> +RC input is configured on the UART4(SERIAL4). It supports all serial RC protocols. SERIAL2_PROTOCOL=23 by default.
+
+
+## OSD Support
+
+StellarH7V2 supports using its internal OSD using OSD_TYPE 1 (MAX7456 driver). External OSD support such as DJI or DisplayPort is supported using any spare UART. See :ref:`common-msp-osd-overview-4.2` for more info.
+
+## PWM Output
+
+StellarH7V2 supports up to 10 PWM outputs. All outputs support DShot.
+
+
+## Battery Monitoring
+
+The board has 1 built-in voltage dividers and 2x current ADC. support external 3.3V based current sensor
+
⬇️ Suggested change
-
+The voltage input is compatible with 2~8S LiPo batteries.
+
+The default battery parameters are:
+
+* :ref:`BATT_MONITOR<BATT_MONITOR>` = 4
+* :ref:`BATT_VOLT_PIN<BATT_VOLT_PIN__AP_BattMonitor_Analog>` = 10
+* :ref:`BATT_CURR_PIN<BATT_CURR_PIN__AP_BattMonitor_Analog>` = 11
+* :ref:`BATT_VOLT_MULT<BATT_VOLT_MULT__AP_BattMonitor_Analog>` = 11
+* :ref:`BATT_AMP_PERVLT<BATT_AMP_PERVLT__AP_BattMonitor_Analog>` = 10
+* :ref:`BATT2_CURR_PIN<BATT2_CURR_PIN__AP_BattMonitor_Analog>` = 7
------------------------------
In libraries/AP_HAL_ChibiOS/hwdef/StellarH7V2/Readme.md
<#28926 (comment)>
:
> +
+## PWM Output
+
+StellarH7V2 supports up to 10 PWM outputs. All outputs support DShot.
+
+
+## Battery Monitoring
+
+The board has 1 built-in voltage dividers and 2x current ADC. support external 3.3V based current sensor
+
+
+## Compass
+
+StellarH7V2 does not have a built-in compass, but you can attach an external compass using I2C on the SDA and SCL pads.
+
+
need to add section on Camera Switch:
⬇️ Suggested change
-
+## Camera Switch
+GPIO 81 controls which camera input (CAM1 or CAM22 is applied to the internal OSD. A RELAY function can be enabled to control the switching.
—
Reply to this email directly, view it on GitHub
<#28926 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGJSSOH23FHUNVQAJZPC3HT2J2NZ3AVCNFSM6AAAAABUAZTRESVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKNBQGI4TEMZXGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
cab185e
to
906b684
Compare
@Hwurzburg @andyp1per could you look at the changes in open issues ? |
906b684
to
6b9c473
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Henry's changes need to be addressed and the commit messages changed
c6687ea
to
4470826
Compare
a41f926
to
cbfbad3
Compare
Hi, I’ll be taking responsibility for this PR as well as any related ones regarding Stellar boards. I’ve made an effort to consolidate feedback and comments from the associated PRs, but please feel free to point out if I’ve missed anything or if there are any additional concerns that need to be addressed. Looking forward to collaborating with everyone to get this merged. Let me know if you have any questions or if further clarification is needed on any part of the changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking very good...a couple of minor things
and a "merge" commit got added...should only have a Tools and a AP_HAL_ChibiOS or hwdef commit (either title works)
* PPM is not supported. | ||
* SBUS/DSM/SRXL connects to the RX4 pin. | ||
* FPort requires connection to TX4 and RX4 via a bi-directional inverter. See :ref:`common-FPort-receivers`. | ||
* CRSF also requires a TX4 connection, in addition to RX6, and automatically provides telemetry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* CRSF also requires a TX4 connection, in addition to RX6, and automatically provides telemetry. | |
* CRSF also requires a TX4 connection, in addition to RX4, and automatically provides telemetry. |
The default RC input is configured on the UART4 RX4 input and can be used for all ArduPilot supported unidirectional receiver protocols. | ||
* PPM is not supported. | ||
* SBUS/DSM/SRXL connects to the RX4 pin. | ||
* FPort requires connection to TX4 and RX4 via a bi-directional inverter. See :ref:`common-FPort-receivers`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* FPort requires connection to TX4 and RX4 via a bi-directional inverter. See :ref:`common-FPort-receivers`. | |
* FPort requires connection to TX4 and :ref:`SERIAL4_OPTIONS<SERIAL4_OPTIONS>` set to "7". See :ref:`common-FPort-receivers`. |
The default battery parameters are: | ||
* :ref:`BATT_MONITOR<BATT_MONITOR>` = 4 | ||
* :ref:`BATT_VOLT_PIN<BATT_VOLT_PIN__AP_BattMonitor_Analog>` = 10 | ||
* :ref:`BATT_CURR_PIN<BATT_CURR_PIN__AP_BattMonitor_Analog>` = 11 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* :ref:`BATT_CURR_PIN<BATT_CURR_PIN__AP_BattMonitor_Analog>` = 11 | |
* :ref:`BATT_CURR_PIN<BATT_CURR_PIN__AP_BattMonitor_Analog>` = 11 (CURR pin) |
* :ref:`BATT_CURR_PIN<BATT_CURR_PIN__AP_BattMonitor_Analog>` = 11 | ||
* :ref:`BATT_VOLT_MULT<BATT_VOLT_MULT__AP_BattMonitor_Analog>` = 11 | ||
* :ref:`BATT_AMP_PERVLT<BATT_AMP_PERVLT__AP_BattMonitor_Analog>` = 10 | ||
* :ref:`BATT2_CURR_PIN<BATT2_CURR_PIN__AP_BattMonitor_Analog>` = 7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* :ref:`BATT2_CURR_PIN<BATT2_CURR_PIN__AP_BattMonitor_Analog>` = 7 | |
* :ref:`BATT2_CURR_PIN<BATT2_CURR_PIN__AP_BattMonitor_Analog>` = 7 (ADC2 pin) |
# USART1 | ||
PA10 USART1_RX USART1 | ||
PA9 USART1_TX USART1 | ||
define DEFAULT_SERIAL1_PROTOCOL SerialProtocol_MAVLink2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove, default already
# USART2 | ||
PD5 USART2_TX USART2 | ||
PD6 USART2_RX USART2 | ||
define DEFAULT_SERIAL1_PROTOCOL SerialProtocol_MAVLink2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove, default already
PB1 TIM3_CH4 TIM3 PWM(2) GPIO(51) # M2 | ||
PA0 TIM5_CH1 TIM5 PWM(3) GPIO(52) BIDIR # M3 | ||
PA1 TIM5_CH2 TIM5 PWM(4) GPIO(53) # M4 | ||
PA2 TIM5_CH3 TIM5 PWM(5) GPIO(54) # M5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PA2 TIM5_CH3 TIM5 PWM(5) GPIO(54) # M5 | |
PA2 TIM5_CH3 TIM5 PWM(5) GPIO(54) BIDIR # M5 |
Thanks for your suggestions. I’ve applied all of them. |
add Stellar H7V2 target