Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP_HAL_ChibiOS: add new target Stellar H7V2 #28926

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

cvetaevvitaliy
Copy link
Contributor

add Stellar H7V2 target

@Hwurzburg
Copy link
Collaborator

Needs full readme with images and pinouts...see other recent hwdefs....should break out board id into separate PR that can be merged before this gets a review in order to reserve the board id...also use the text board name instead of number in the hwdefs

@cvetaevvitaliy
Copy link
Contributor Author

Needs full readme with images and pinouts...see other recent hwdefs....should break out board id into separate PR that can be merged before this gets a review in order to reserve the board id...also use the text board name instead of number in the hwdefs

Done

#28929

@cvetaevvitaliy cvetaevvitaliy changed the title add Stellar H7V2 target AP_HAL_ChibiOS: add new target Stellar H7V2 Dec 22, 2024
Copy link
Collaborator

@andyp1per andyp1per left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commits need to be squashed per subsystem and labeled according to our coding standards. Please see https://ardupilot.org/dev/docs/submitting-patches-back-to-master.html

libraries/AP_HAL_ChibiOS/hwdef/StellarH7V2/hwdef.dat Outdated Show resolved Hide resolved
PD9 USART3_RX USART3
PD8 USART3_TX USART3

# UART4 (spare)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RCIN according to the picture?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UART4

libraries/AP_HAL_ChibiOS/hwdef/StellarH7V2/hwdef.dat Outdated Show resolved Hide resolved
libraries/AP_HAL_ChibiOS/hwdef/StellarH7V2/Readme.md Outdated Show resolved Hide resolved
# Motors
PB0 TIM3_CH3 TIM3 PWM(1) BIDIR GPIO(50)
PB1 TIM3_CH4 TIM3 PWM(2) GPIO(51)
PA0 TIM5_CH1 TIM5 PWM(3) GPIO(52)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should at least add it to PWM3 as well so that you can support a quad with bi-dir

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should come at the end of the line

Copy link
Collaborator

@Hwurzburg Hwurzburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you will also need to squash the commits into one for the Tools library titled
Tools:add StellarH7V2

and one for the hwdef library titled
HWDEF: add StellarH7V2

Please make similar changes as from this review to PR#28925 StellarF4 and then I will review it also

libraries/AP_HAL_ChibiOS/hwdef/StellarH7V2/Readme.md Outdated Show resolved Hide resolved
libraries/AP_HAL_ChibiOS/hwdef/StellarH7V2/Readme.md Outdated Show resolved Hide resolved
12V, 3A BEC for powering Video Transmitter
5V, 2A BEC for internal and peripherals
Interfaces
10x PWM outputs DShot capable
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see only 8 outputs on the board, what am I missing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where is PWM8 and 9?

libraries/AP_HAL_ChibiOS/hwdef/StellarH7V2/Readme.md Outdated Show resolved Hide resolved
1x CAN
1x I2C
3x ADC
SD card and 128/256MB NAND for logging
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
SD card and 128/256MB NAND for logging
micro-SD card interface

libraries/AP_HAL_ChibiOS/hwdef/StellarH7V2/Readme.md Outdated Show resolved Hide resolved

## OSD Support

StellarH7V2 supports using its internal OSD using OSD_TYPE 1 (MAX7456 driver). External OSD support such as DJI or DisplayPort is supported using any spare UART. See :ref:`common-msp-osd-overview-4.2` for more info.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
StellarH7V2 supports using its internal OSD using OSD_TYPE 1 (MAX7456 driver). External OSD support such as DJI or DisplayPort is supported using any spare UART. See :ref:`common-msp-osd-overview-4.2` for more info.
StellarH7V2 supports using its internal OSD using OSD_TYPE 1 (MAX7456 driver). Simulatenous DisplayPort OSD operation is preconfigured on SERIAL 6 but requires OSD_TYPE2 = 5. See :ref:`common-msp-osd-overview-4.2` for more info.

@cvetaevvitaliy
Copy link
Contributor Author

cvetaevvitaliy commented Jan 9, 2025 via email

@cvetaevvitaliy
Copy link
Contributor Author

@Hwurzburg @andyp1per could you look at the changes in open issues ?
Thanks

Copy link
Collaborator

@andyp1per andyp1per left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Henry's changes need to be addressed and the commit messages changed

PB1 TIM3_CH4 TIM3 PWM(2) GPIO(51)
PA0 TIM5_CH1 TIM5 PWM(3) BIDIR GPIO(52)
PA1 TIM5_CH2 TIM5 PWM(4) GPIO(53)
PA2 TIM5_CH3 TIM5 PWM(5) GPIO(54)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may as well add BIDIR to PWM(5) as well - there is no downside with this configuration

@cvetaevvitaliy cvetaevvitaliy force-pushed the stellar-h7v2 branch 2 times, most recently from e3c827f to e5dfaa2 Compare January 16, 2025 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants