add DroneerF405 hwdef #28846

DroneerUAV · 2024-12-12T09:06:12Z

Add DroneerF405 board from Droneer UAV

andyp1per · 2024-12-12T15:36:20Z

I recommend these changes:

diff --git a/libraries/AP_HAL_ChibiOS/hwdef/DroneerF405/hwdef.dat b/libraries/AP_HAL_ChibiOS/hwdef/DroneerF405/hwdef.dat
index 4063f183a1..96d622b26a 100644
--- a/libraries/AP_HAL_ChibiOS/hwdef/DroneerF405/hwdef.dat
+++ b/libraries/AP_HAL_ChibiOS/hwdef/DroneerF405/hwdef.dat
@@ -34,14 +34,14 @@ PA12 OTG_FS_DP OTG1
 PC5 VBUS INPUT OPENDRAIN

 # USART1(VTX)
-PA9  USART1_TX USART1
-PA10 USART1_RX USART1
+PA9  USART1_TX USART1 NODMA
+PA10 USART1_RX USART1 NODMA
 define DEFAULT_SERIAL1_PROTOCOL SerialProtocol_Tramp

 # USART2, RC input
 PA2 USART2_TX USART2
-PA3 USART2_RX USART2 NODMA
-define DEFAULT_SERIAL2_PROTOCOL SerialProtocol_MAVLink2
+PA3 USART2_RX USART2
+define DEFAULT_SERIAL2_PROTOCOL SerialProtocol_RCIN

 # default to timer for RC input
 #PA3 TIM9_CH2 TIM9 RCININT PULLDOWN LOW
@@ -70,10 +70,10 @@ define DEFAULT_SERIAL5_PROTOCOL SerialProtocol_None

 # PWM output. 1 - 8 on ESC header
 # --------------------- PWM -----------------------
-PC6  TIM8_CH1   TIM8  PWM(1)  GPIO(50)
+PC6  TIM8_CH1   TIM8  PWM(1)  GPIO(50) BIDIR
 PC7  TIM8_CH2   TIM8  PWM(2)  GPIO(51)
 PC8  TIM8_CH3   TIM8  PWM(3)  GPIO(52)
-PC9  TIM8_CH4   TIM8  PWM(4)  GPIO(53)
+PC9  TIM8_CH4   TIM8  PWM(4)  GPIO(53) BIDIR
 PA15 TIM2_CH1   TIM2  PWM(5)  GPIO(54)
 PA8  TIM1_CH1   TIM1  PWM(6)  GPIO(55)
 PB10 TIM2_CH3   TIM2  PWM(7)  GPIO(56)
@@ -174,7 +174,7 @@ define HAL_OSD_TYPE_DEFAULT 1
 # Font for the osd
 ROMFS_WILDCARD libraries/AP_OSD/fonts/font*.bin

-DMA_PRIORITY TIM2* TIM3*
+DMA_PRIORITY TIM8* TIM3*

 # minimal drivers to reduce flash usage
 include ../include/minimize_fpv_osd.inc

andyp1per

Needs a README.md
Suggest the changes I outlined

libraries/AP_HAL_ChibiOS/hwdef/DroneerF405/hwdef-bl.dat

libraries/AP_HAL_ChibiOS/hwdef/DroneerF405/hwdef.dat

DroneerUAV · 2024-12-16T10:15:11Z

我建议进行以下更改：

diff --git a/libraries/AP_HAL_ChibiOS/hwdef/DroneerF405/hwdef.dat b/libraries/AP_HAL_ChibiOS/hwdef/DroneerF405/hwdef.dat
index 4063f183a1..96d622b26a 100644
--- a/libraries/AP_HAL_ChibiOS/hwdef/DroneerF405/hwdef.dat
+++ b/libraries/AP_HAL_ChibiOS/hwdef/DroneerF405/hwdef.dat
@@ -34,14 +34,14 @@ PA12 OTG_FS_DP OTG1
 PC5 VBUS INPUT OPENDRAIN

 # USART1(VTX)
-PA9  USART1_TX USART1
-PA10 USART1_RX USART1
+PA9  USART1_TX USART1 NODMA
+PA10 USART1_RX USART1 NODMA
 define DEFAULT_SERIAL1_PROTOCOL SerialProtocol_Tramp

 # USART2, RC input
 PA2 USART2_TX USART2
-PA3 USART2_RX USART2 NODMA
-define DEFAULT_SERIAL2_PROTOCOL SerialProtocol_MAVLink2
+PA3 USART2_RX USART2
+define DEFAULT_SERIAL2_PROTOCOL SerialProtocol_RCIN

 # default to timer for RC input
 #PA3 TIM9_CH2 TIM9 RCININT PULLDOWN LOW
@@ -70,10 +70,10 @@ define DEFAULT_SERIAL5_PROTOCOL SerialProtocol_None

 # PWM output. 1 - 8 on ESC header
 # --------------------- PWM -----------------------
-PC6  TIM8_CH1   TIM8  PWM(1)  GPIO(50)
+PC6  TIM8_CH1   TIM8  PWM(1)  GPIO(50) BIDIR
 PC7  TIM8_CH2   TIM8  PWM(2)  GPIO(51)
 PC8  TIM8_CH3   TIM8  PWM(3)  GPIO(52)
-PC9  TIM8_CH4   TIM8  PWM(4)  GPIO(53)
+PC9  TIM8_CH4   TIM8  PWM(4)  GPIO(53) BIDIR
 PA15 TIM2_CH1   TIM2  PWM(5)  GPIO(54)
 PA8  TIM1_CH1   TIM1  PWM(6)  GPIO(55)
 PB10 TIM2_CH3   TIM2  PWM(7)  GPIO(56)
@@ -174,7 +174,7 @@ define HAL_OSD_TYPE_DEFAULT 1
 # Font for the osd
 ROMFS_WILDCARD libraries/AP_OSD/fonts/font*.bin

-DMA_PRIORITY TIM2* TIM3*
+DMA_PRIORITY TIM8* TIM3*

 # minimal drivers to reduce flash usage
 include ../include/minimize_fpv_osd.inc

Does the suggestion here need to be changed? Our hardware serial port 2 must be added with NODMA in order to work normally

andyp1per · 2024-12-30T17:33:15Z

我建议进行以下更改：

diff --git a/libraries/AP_HAL_ChibiOS/hwdef/DroneerF405/hwdef.dat b/libraries/AP_HAL_ChibiOS/hwdef/DroneerF405/hwdef.dat
index 4063f183a1..96d622b26a 100644
--- a/libraries/AP_HAL_ChibiOS/hwdef/DroneerF405/hwdef.dat
+++ b/libraries/AP_HAL_ChibiOS/hwdef/DroneerF405/hwdef.dat
@@ -34,14 +34,14 @@ PA12 OTG_FS_DP OTG1
 PC5 VBUS INPUT OPENDRAIN

 # USART1(VTX)
-PA9  USART1_TX USART1
-PA10 USART1_RX USART1
+PA9  USART1_TX USART1 NODMA
+PA10 USART1_RX USART1 NODMA
 define DEFAULT_SERIAL1_PROTOCOL SerialProtocol_Tramp

 # USART2, RC input
 PA2 USART2_TX USART2
-PA3 USART2_RX USART2 NODMA
-define DEFAULT_SERIAL2_PROTOCOL SerialProtocol_MAVLink2
+PA3 USART2_RX USART2
+define DEFAULT_SERIAL2_PROTOCOL SerialProtocol_RCIN

 # default to timer for RC input
 #PA3 TIM9_CH2 TIM9 RCININT PULLDOWN LOW
@@ -70,10 +70,10 @@ define DEFAULT_SERIAL5_PROTOCOL SerialProtocol_None

 # PWM output. 1 - 8 on ESC header
 # --------------------- PWM -----------------------
-PC6  TIM8_CH1   TIM8  PWM(1)  GPIO(50)
+PC6  TIM8_CH1   TIM8  PWM(1)  GPIO(50) BIDIR
 PC7  TIM8_CH2   TIM8  PWM(2)  GPIO(51)
 PC8  TIM8_CH3   TIM8  PWM(3)  GPIO(52)
-PC9  TIM8_CH4   TIM8  PWM(4)  GPIO(53)
+PC9  TIM8_CH4   TIM8  PWM(4)  GPIO(53) BIDIR
 PA15 TIM2_CH1   TIM2  PWM(5)  GPIO(54)
 PA8  TIM1_CH1   TIM1  PWM(6)  GPIO(55)
 PB10 TIM2_CH3   TIM2  PWM(7)  GPIO(56)
@@ -174,7 +174,7 @@ define HAL_OSD_TYPE_DEFAULT 1
 # Font for the osd
 ROMFS_WILDCARD libraries/AP_OSD/fonts/font*.bin

-DMA_PRIORITY TIM2* TIM3*
+DMA_PRIORITY TIM8* TIM3*

 # minimal drivers to reduce flash usage
 include ../include/minimize_fpv_osd.inc

Does the suggestion here need to be changed? Our hardware serial port 2 must be added with NODMA in order to work normally

I don't think so. We discussed this on discord, you need to use an actual serial protocol

DroneerUAV · 2025-01-08T08:23:26Z

@andyp1per I have addressed the requested changes,Please review the updated PR

andyp1per

Looking good

Tools/AP_Bootloader/board_types.txt

Hwurzburg

in addition to changes listed, commits will need to be squashed and then split into one for Tools: add DronnerF405(for Tools library files)
and hwdef: add DroneerF405(for hwdef library files)

libraries/AP_HAL_ChibiOS/hwdef/DroneerF405/hwdef-bl.dat

libraries/AP_HAL_ChibiOS/hwdef/DroneerF405/hwdef.dat

libraries/AP_HAL_ChibiOS/hwdef/DroneerF405/README.md

DroneerUAV · 2025-01-14T02:03:22Z

in addition to changes listed, commits will need to be squashed and then split into one for Tools: add DronnerF405(for Tools library files) and hwdef: add DroneerF405(for hwdef library files)

I've made all the required changes, please review

andyp1per · 2025-01-15T18:08:56Z

Apologies, the commit messages need to match the module names so:
Tools -> bootloaders
hwdef->AP_HAL_ChibiOS

andyp1per

Some changes needed

Tools/AP_Bootloader/board_types.txt

DroneerUAV · 2025-01-16T09:05:52Z

Apologies, the commit messages need to match the module names so: Tools -> bootloaders hwdef->AP_HAL_ChibiOS

the commit message,like this?
Tools -> bootloaders: add DroneerF405
AP_HAL_ChibiOS->hwdef: add DroneerF405

andyp1per · 2025-01-16T09:17:22Z

Like this:

bootloaders: add DroneerF405
AP_HAL_ChibiOS: add DroneerF405

and you actually need to split the bootloaders commit into two since the board id is in a separate module:

AP_Bootloader: add DroneerF405

DroneerUAV · 2025-01-16T09:20:52Z

Like this:
bootloaders: add DroneerF405
AP_HAL_ChibiOS: add DroneerF405
and you actually need to split the bootloaders commit into two since the board id is in a separate module:
AP_Bootloader: add DroneerF405

ok,got it

DroneerUAV · 2025-01-16T10:24:12Z

Like this:
bootloaders: add DroneerF405
AP_HAL_ChibiOS: add DroneerF405
and you actually need to split the bootloaders commit into two since the board id is in a separate module:
AP_Bootloader: add DroneerF405

I've made all the required changes, please review

Hwurzburg · 2025-01-16T13:20:53Z

@DroneerUAV I have made a few changes that you had missed and cleaned up the RC section in the readme, rebased, and pushed here....should be good to go now

DroneerUAV · 2025-01-17T01:19:53Z

@DroneerUAV I have made a few changes that you had missed and cleaned up the RC section in the readme, rebased, and pushed here....should be good to go now

ok, thank you,Is there anything else I need to do

Hwurzburg · 2025-01-17T03:06:50Z

I dont think so.. @andyp1per can you approve?

andyp1per

LGTM, needs a rebase

DroneerUAV · 2025-01-20T02:41:37Z

LGTM, needs a rebase

I have rebase to the latest

peterbarker · 2025-01-20T06:21:27Z

Merged this, thanks @DroneerUAV . Please note in future you might want to create a topic branch to create your pull request from; using your master branch for this sort of thing isn't great :-) See https://ardupilot.org/dev/docs/git-branch.html

DroneerUAV · 2025-01-20T06:35:15Z

Merged this, thanks @DroneerUAV . Please note in future you might want to create a topic branch to create your pull request from; using your master branch for this sort of thing isn't great :-) See https://ardupilot.org/dev/docs/git-branch.html

ok,got it,thanks

andyp1per requested changes Dec 12, 2024

View reviewed changes

libraries/AP_HAL_ChibiOS/hwdef/DroneerF405/hwdef-bl.dat Outdated Show resolved Hide resolved

libraries/AP_HAL_ChibiOS/hwdef/DroneerF405/hwdef.dat Outdated Show resolved Hide resolved

peterbarker added the NewBoardSupport label Dec 13, 2024

Hwurzburg self-requested a review December 25, 2024 16:28

DroneerUAV force-pushed the master branch from 8e65ad1 to 5998b34 Compare January 8, 2025 06:48

DroneerUAV force-pushed the master branch from 5998b34 to a0714a2 Compare January 8, 2025 10:42

andyp1per requested changes Jan 8, 2025

View reviewed changes

Tools/AP_Bootloader/board_types.txt Outdated Show resolved Hide resolved

DroneerUAV force-pushed the master branch from a0714a2 to a2996a1 Compare January 9, 2025 00:37

Hwurzburg requested changes Jan 11, 2025

View reviewed changes

DroneerUAV force-pushed the master branch from a2996a1 to 3d5a6ea Compare January 14, 2025 02:01

andyp1per requested changes Jan 15, 2025

View reviewed changes

Tools/AP_Bootloader/board_types.txt Show resolved Hide resolved

DroneerUAV force-pushed the master branch from 3d5a6ea to fdfa823 Compare January 16, 2025 10:22

Hwurzburg force-pushed the master branch 2 times, most recently from 1d269d1 to 0b1b959 Compare January 16, 2025 13:19

Hwurzburg added the DevCallTopic label Jan 16, 2025

Hwurzburg approved these changes Jan 16, 2025

View reviewed changes

Hwurzburg requested review from andyp1per and peterbarker January 16, 2025 13:21

Hwurzburg force-pushed the master branch from 0b1b959 to 55f1190 Compare January 16, 2025 13:47

Hwurzburg added the WikiNeeded needs wiki update label Jan 17, 2025

andyp1per approved these changes Jan 18, 2025

View reviewed changes

Zedd-Chen added 3 commits January 19, 2025 18:19

AP_Bootloader: add DroneerF405

602e058

bootloaders: add DroneerF405

72d85a2

AP_HAL_ChibiOS: add DroneerF405

015eecc

DroneerUAV force-pushed the master branch from 55f1190 to 015eecc Compare January 20, 2025 02:25

peterbarker merged commit 1dae851 into ArduPilot:master Jan 20, 2025
50 checks passed

IamPete1 removed the DevCallTopic label Jan 20, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add DroneerF405 hwdef #28846

add DroneerF405 hwdef #28846

DroneerUAV commented Dec 12, 2024 •

edited

Loading

andyp1per commented Dec 12, 2024 •

edited

Loading

andyp1per left a comment

DroneerUAV commented Dec 16, 2024

andyp1per commented Dec 30, 2024

DroneerUAV commented Jan 8, 2025

andyp1per left a comment

Hwurzburg left a comment

DroneerUAV commented Jan 14, 2025

andyp1per commented Jan 15, 2025

andyp1per left a comment

DroneerUAV commented Jan 16, 2025 •

edited

Loading

andyp1per commented Jan 16, 2025 •

edited

Loading

DroneerUAV commented Jan 16, 2025

DroneerUAV commented Jan 16, 2025

Hwurzburg commented Jan 16, 2025

DroneerUAV commented Jan 17, 2025

Hwurzburg commented Jan 17, 2025

andyp1per left a comment

DroneerUAV commented Jan 20, 2025

peterbarker commented Jan 20, 2025

DroneerUAV commented Jan 20, 2025

add DroneerF405 hwdef #28846

add DroneerF405 hwdef #28846

Conversation

DroneerUAV commented Dec 12, 2024 • edited Loading

andyp1per commented Dec 12, 2024 • edited Loading

andyp1per left a comment

Choose a reason for hiding this comment

DroneerUAV commented Dec 16, 2024

andyp1per commented Dec 30, 2024

DroneerUAV commented Jan 8, 2025

andyp1per left a comment

Choose a reason for hiding this comment

Hwurzburg left a comment

Choose a reason for hiding this comment

DroneerUAV commented Jan 14, 2025

andyp1per commented Jan 15, 2025

andyp1per left a comment

Choose a reason for hiding this comment

DroneerUAV commented Jan 16, 2025 • edited Loading

andyp1per commented Jan 16, 2025 • edited Loading

DroneerUAV commented Jan 16, 2025

DroneerUAV commented Jan 16, 2025

Hwurzburg commented Jan 16, 2025

DroneerUAV commented Jan 17, 2025

Hwurzburg commented Jan 17, 2025

andyp1per left a comment

Choose a reason for hiding this comment

DroneerUAV commented Jan 20, 2025

peterbarker commented Jan 20, 2025

DroneerUAV commented Jan 20, 2025

DroneerUAV commented Dec 12, 2024 •

edited

Loading

andyp1per commented Dec 12, 2024 •

edited

Loading

DroneerUAV commented Jan 16, 2025 •

edited

Loading

andyp1per commented Jan 16, 2025 •

edited

Loading