-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AP_VideoTX / AP_OSD: Make VTX temperature available for OSD #28599
Conversation
OK, I have tested and I can see the OSD element but the temperature keeps at 80°C the whole time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Main problem is parameter changes
Make VTX temperature from AP_Tramp available through AP_VideoTX class.
Make VTX temperature visible through OSD.
51cbadf
to
a315bad
Compare
Added changes to the bottom of each location instead of mixing it inside other items. |
OK, I get it, now I have cross talk with TER_HGT. I'll try with a new Group. |
I'm getting the impression, that the referenced temperature in AP_Tramp is a thermal protection threshold and not a measurement. |
I'll see that I get a second Tramp VTX to solder into some betaflight setup for comparism. https://betaflight.com/docs/wiki/guides/current/irc-tramp Just checked that INAV does not have this feature via the stick OSD. Betaflight should still have it but they did not have a firmware image for the speedybee f405 wing mini |
This PR is void. I received feedback from ImmersionRC / Orqa FPV that this value is a thermal setpoint, means it's stupid to view on OSD. I'll do something else in another PR to write that setpoint and provide a setpoint value from ardupilot parameters. |
This patch adds VTX temperature forwarding from AP_Tramp through AP_VideoTX to AP_OSD.
I would appreciate feedback about style and correct use of methods because I merely copied code sections based on assumptions without digging too deep into the macros etc.