Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP_VideoTX / AP_OSD: Make VTX temperature available for OSD #28599

Closed
wants to merge 3 commits into from

Conversation

menschel
Copy link
Contributor

This patch adds VTX temperature forwarding from AP_Tramp through AP_VideoTX to AP_OSD.

I would appreciate feedback about style and correct use of methods because I merely copied code sections based on assumptions without digging too deep into the macros etc.

@menschel
Copy link
Contributor Author

OK, I have tested and I can see the OSD element but the temperature keeps at 80°C the whole time.
Has this been tested on AP_Tramp, i.e. does the value saved there is accurate ?

Copy link
Collaborator

@andyp1per andyp1per left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Main problem is parameter changes

libraries/AP_OSD/AP_OSD_Screen.cpp Outdated Show resolved Hide resolved
libraries/AP_VideoTX/AP_VideoTX.h Outdated Show resolved Hide resolved
libraries/AP_VideoTX/AP_VideoTX.h Outdated Show resolved Hide resolved
Make VTX temperature from AP_Tramp available through AP_VideoTX class.
Make VTX temperature visible through OSD.
@menschel
Copy link
Contributor Author

Added changes to the bottom of each location instead of mixing it inside other items.
Do I really need to open up a new group for my parameter? I assume Index 63 is allowed, yes?

@menschel menschel requested a review from andyp1per November 13, 2024 17:57
@menschel
Copy link
Contributor Author

OK, I get it, now I have cross talk with TER_HGT. I'll try with a new Group.

@menschel
Copy link
Contributor Author

I'm getting the impression, that the referenced temperature in AP_Tramp is a thermal protection threshold and not a measurement.

@menschel
Copy link
Contributor Author

I'll see that I get a second Tramp VTX to solder into some betaflight setup for comparism.

https://betaflight.com/docs/wiki/guides/current/irc-tramp

Just checked that INAV does not have this feature via the stick OSD.
They threw it out in 2020
iNavFlight/inav@9159431

Betaflight should still have it but they did not have a firmware image for the speedybee f405 wing mini
https://github.com/betaflight/betaflight/blob/master/src/main/cms/cms_menu_vtx_tramp.c#L89C5-L89C17

@menschel
Copy link
Contributor Author

This PR is void.

I received feedback from ImmersionRC / Orqa FPV that this value is a thermal setpoint, means it's stupid to view on OSD.

I'll do something else in another PR to write that setpoint and provide a setpoint value from ardupilot parameters.

@menschel menschel closed this Nov 21, 2024
@menschel menschel deleted the pr-feat-vtxtemp branch November 21, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants