Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plane: added glider pullup support #27985

Merged
merged 5 commits into from
Sep 10, 2024
+456 −8
Merged

Plane: added glider pullup support #27985

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ab95fb4
SRV_Channel: added lift_release
tridge Aug 30, 2024
085b081
Tools: added AP_PLANE_GLIDER_PULLUP_ENABLED feature
tridge Sep 2, 2024
f5f62d5
Plane: added glider pullup support
tridge Aug 30, 2024
ba0a8c0
autotest: added GliderPullup test
tridge Sep 2, 2024
2227e00
Plane: don't run TECS update_speed_height() when in idle mode
tridge Sep 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
SRV_Channel: added lift_release 
for releasing a balloon or other lift device
@tridge
tridge committed Sep 9, 2024
commit ab95fb4c6385cfa59296fc08e2aae3580d111a93
1 change: 1 addition & 0 deletions libraries/SRV_Channel/SRV_Channel.h
View file
Original file line number Diff line number Diff line change
@@ -188,6 +188,7 @@ class SRV_Channel {
k_rcin14_mapped = 153,
k_rcin15_mapped = 154,
k_rcin16_mapped = 155,
k_lift_release = 156,
k_nr_aux_servo_functions ///< This must be the last enum value (only add new values _before_ this one)
} Aux_servo_function_t;

1 change: 1 addition & 0 deletions libraries/SRV_Channel/SRV_Channel_aux.cpp
View file
Original file line number Diff line number Diff line change
@@ -140,6 +140,7 @@ void SRV_Channel::aux_servo_function_setup(void)
case k_flap:
case k_flap_auto:
case k_egg_drop:
case k_lift_release:
set_range(100);
Comment on lines +143 to 144
Copy link
Member

@IamPete1 IamPete1 Sep 3, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to start setting range/angle of 1 for new things.

Suggested change
case k_lift_release:
set_range(100);
set_range(100);
case k_lift_release:
set_range(1);

Eventually we can get rid of all the * 4500

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are no set_range(1) calls in master right now, and while the range is a uint16_t I don't think 1 is a good choice as a default as it means it can only be binary. That is OK for this case, but not a good pattern

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see #27985 (comment)

break;
case k_heli_rsc: