hwdef: add CubeOrangePlus-ODID hwdef #27561
Conversation
BryonOI
changed the title
| define CORE_CM7 | ||
| define SMPS_PWR | ||
|
|
||
| include ../CubeOrange/hwdef.inc |
There was a problem hiding this comment.
Why is this not including CubeOrangePlus/hwdef.dat?
There was a problem hiding this comment.
I did not change this as this is how the original CubeOrangePlus hwdef file was formatted. This section is identical to the CubeOrangePlus hwdef aside from the updated board id. Does this need to be changed?
There was a problem hiding this comment.
I have tested this to include CubeOrangePlus/hwdef.dat. These changes cause an error when configuring the board due to PF14 redefinition. I have not changed this file in the PR as it does not seem to reflect the original CubeOrangePlus build configurations. Please let me know if you have further questions or requests for this PR.
There was a problem hiding this comment.
So the concept is that you include CubeOrangePlus/hwdef.dat and put in just what you need to to do ODID.
Check out how CubeOrange-ODID does it.
There was a problem hiding this comment.
@BryonOI you still haven't addressed this comment.
The entirety of this file can simply be:
# hw definition file for processing by chibios_hwdef.py
include ../CubeOrangePlus/hwdef.dat
undef APJ_BOARD_ID
APJ_BOARD_ID 11063
define AP_OPENDRONEID_ENABLED 1
Similarly for the -bl file.
|
Please note our requirements on commit history - this should be a single commit titled |
|
Could you outline how this fulfills your needs, please? My concern is that we have dozens of boards that could have ODID variants made for them, but often vendors believe they need to do more to satisfy ODID requirements. The costs are (a) complication for maintenance of the project and (b) build time on our build server, which generates binaries for commits to our master branch (and for releases). It's OK to merge this, but we do need to know it's doing someone some actual good. |
Thank you for your reply! Overhead Intelligence utilizes both the CubeOrange and CubeOrangePlus on our fleet of drones. Including the CubeOrangePlus-ODID firmware to the hwdef boardlist will allow us to quickly access the new firmware from the remote master branch of ArduPilot, which we are already working with. I have implemented the CubeOrangePlus-ODID firmware into many functioning ArduPilot platforms with no errors. Including the CubeOrangePlus-ODID firmware would allow Overhead Intelligence and many others using the CubeOrangePlus to easily upload the new ODID firmware to future drones using ArduPilot software. |
BryonOI
changed the title
There was a problem hiding this comment.
@Hwurzburg do we need all of the documentation copied over into this new board or not?
@BryonOI you're still interested in chasing this?
| define CORE_CM7 | ||
| define SMPS_PWR | ||
|
|
||
| include ../CubeOrange/hwdef.inc |
There was a problem hiding this comment.
@BryonOI you still haven't addressed this comment.
The entirety of this file can simply be:
# hw definition file for processing by chibios_hwdef.py
include ../CubeOrangePlus/hwdef.dat
undef APJ_BOARD_ID
APJ_BOARD_ID 11063
define AP_OPENDRONEID_ENABLED 1
Similarly for the -bl file.
|
@peterbarker if this is simply an ODID version I don't think we need dup docs from the Plus |
Yes it would be very beneficial to our team. I have modified the hwdef.dat and hwdef-bl.dat files accordingly. Please let me know if there is anything else needed for this merge request to be approved. |
|
@peterbarker ping |
| # setup correct defaults for battery monitoring for cube power brick | ||
| BATT2_CURR_PIN 4 | ||
| BATT2_VOLT_PIN 13 | ||
| BATT_AMP_PERVLT 39.877 | ||
| BATT_VOLT_MULT 12.02 | ||
| BATT2_AMP_PERVLT 39.877 | ||
| BATT2_VOLT_MULT 12.02 | ||
| # setup ADSB | ||
| ADSB_TYPE 1 | ||
| SERIAL5_BAUD 57 | ||
| SERIAL5_PROTOCOL 1 |
There was a problem hiding this comment.
| # setup correct defaults for battery monitoring for cube power brick | |
| BATT2_CURR_PIN 4 | |
| BATT2_VOLT_PIN 13 | |
| BATT_AMP_PERVLT 39.877 | |
| BATT_VOLT_MULT 12.02 | |
| BATT2_AMP_PERVLT 39.877 | |
| BATT2_VOLT_MULT 12.02 | |
| # setup ADSB | |
| ADSB_TYPE 1 | |
| SERIAL5_BAUD 57 | |
| SERIAL5_PROTOCOL 1 | |
| @include ./CubeOrangePlus/defaults.parm |
| GPS1_TYPE 1 | ||
| GPS2_TYPE 0 | ||
|
|
||
| EK2_PRIMARY 1 |
There was a problem hiding this comment.
| EK2_PRIMARY 1 |
... this parameter's never existed :-)
| GPS1_TYPE 1 | ||
| GPS2_TYPE 0 | ||
|
|
||
| EK2_PRIMARY 1 |
There was a problem hiding this comment.
Really not sure what these are doing in here. I can see you've just swiped them in from the other file.... but still odd.
There was a problem hiding this comment.
I removed these three parameters and committed the changes. Let me know if there is anything else you catch!
…Removed extraneous GPS1_Type and GPS2_Type parameters.
…ngePlus-ODID into BryonOI/master
Hwurzburg
added
WikiNeeded
Bootloaders:
Add CubeOrangePlus-ODID hardware def bootloader files for remote ID support.