Tools: add ignore information in ros-ubuntu installation shell

[lukezhqin]

#22482

[rmackay9]

Hi @lukezhqin,

Thanks very much for this. Can you change the prefix from "fix:" to "Tools:"?

[lukezhqin]

Hi @lukezhqin,

Thanks very much for this. Can you change the prefix from "fix:" to "Tools:"?

@rmackay9 I've already change the name and the commit comment also, thanks!

[rmackay9]

@srmainwaring @jmachuca77 @snktshrma

how does this look to you guys?

[rmackay9]

I've received some external comments from @jmachuca77 who thinks that the "-i" may not be necessary. Also he wonders if it is a good idea to ignore errors. Isn't it important to see errors?

[lukezhqin]

I've received some external comments from @jmachuca77 who thinks that the "-i" may not be necessary. Also he wonders if it is a good idea to ignore errors. Isn't it important to see errors?

I remove this '-i' as a new commit here.

Indeed, The option "-r" just ignores the errors and keep installing the required dependencies. However, I just install ROS using this script, but got error then. I refer to this LINK and solve this error, which displayed as ""Cannot locate rosdep"". Didn't anyone else met same installation issue?

[srmainwaring]

There are still some issues with the script when running on an Ubuntu 20.04 VM.

Host: macOS Monterey 12.6, Intel Mac Pro
System: Ubuntu Focal 20.04.5 LTS on VMware Fusion 13.0

After:

Add ardupilot-ws to your home folder [N/y]? y

we eventually see:

ardupilot_ros: Cannot locate rosdep definition for [cartographer_ros]

This is because the Noetic distro https://github.com/ros/rosdistro/blob/master/noetic/distribution.yaml does not have an entry for cartographer_ros. The Melodic distro https://github.com/ros/rosdistro/blob/master/melodic/distribution.yaml does have an entry at L1166:

  cartographer_ros:
    doc:
      type: git
      url: https://github.com/googlecartographer/cartographer_ros.git
      version: 1.0.0
    release:
      packages:
      - cartographer_ros
      - cartographer_ros_msgs
      - cartographer_rviz
      tags:
        release: release/melodic/{package}/{version}
      url: https://github.com/ros-gbp/cartographer_ros-release.git
      version: 1.0.0-1
    status: developed

=> ignoring the errors with the -r flag will cause issues later on some platforms.

We may need to extend the rosdep rules. According to https://answers.ros.org/question/207771/custom-rosdepyaml-in-my-package/ custom rules for a package are no longer supported. Instead we can contribute rules using http://docs.ros.org/en/independent/api/rosdep/html/contributing_rules.html. Or in the meanwhile, if we don't want an upstream dependency, we add a step to the script to clone the additional dependencies into ardupilot-ws/src?

[snktshrma]

Hi @srmainwaring!
I am aware of the cartographer issue and working on it to resolve the build issue!
Will make a pr soon!

[srmainwaring]

am aware of the cartographer issue and working on it to resolve the build issue!

@snktshrma do you plan to edit the rosdep yaml (one way would be to add an entry in /etc/apt/sources.list.d/ros-latest.list pointing to a custom yaml maintained by ardupilot, or add another file), or will you take a different approach? Happy to test now I have an environment set up.

[snktshrma]

@srmainwaring I am thinking to add a rosinstall file with the ardupilot_ros repo. This rosinstall file will point to cartographer and cartographer_ros repositories and will be installed through wstools. This can be a good approach to resolve the issue. Do let me know your views.
Also I am working to resolve all the issues with the install script and will make a PR in a couple of days

[Ryanf55]

The dev team is currently only able to support ROS 2. If anyone wants to contribute a fix for the ROS install that works with ROS 1 melodic, go for it, but adding -r does not fix the root cause problem on ROS 1 noetic of the package not being available in ROS distro.