[C++ cmd] Make CommandGenericHID as a public base class of CommandXboxController #6658
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6296 accidentally omitted the
public
specifier onCommandGenericHID
in the base class section ofCommandXboxController
. SinceCommandXboxController
is declared usingclass
, the default access for base classes is private, which prevents users outside the class from using methods declared inCommandGenericHID
, which was the point of the PR.I checked and the other files touched by that PR do not have the issue. I also confirmed locally that using methods declared in
CommandGenericHID
(such asButton(int)
) on aCommandXboxController
works with the following diff: