Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 3D scanner alignment correction offset #5

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

craig-willis
Copy link
Collaborator

@craig-willis craig-willis commented Feb 1, 2017

@craig-willis craig-willis changed the title Added alignment offset Added 3D scanner alignment correction offset Feb 1, 2017
@ghost
Copy link

ghost commented May 25, 2017

@solmazhajmohammadi - please review

@ghost ghost assigned craig-willis May 25, 2017
@ghost
Copy link

ghost commented May 25, 2017

delayed because offset is temperature dependent. @solmazhajmohammadi will update with additional data.

@pless
Copy link

pless commented Jul 13, 2017

Can someone comment on the magnitude of the temperature sensitivity? Is it a few millimeters? a few centimeters? more?

@solmazhajmohammadi
Copy link

@pless The offset goes up to 4-5 cm, See the plot below:
picture1

@dlebauer
Copy link
Member

@solmazhajmohammadi can you please update these values with the fixed numbers we should use in the pipeline?

@dlebauer
Copy link
Member

Please also add quantitative est. of error + qualitative description of assumptions. Indicate that it is not temp. corrected, and that resulting error is in absolute position rather than any distortion, plus other relevant technical information.

@solmazhajmohammadi
Copy link

A fixed number for the offset would be zero, and we can add the offset based on the model explained above.

Copy link

@solmazhajmohammadi solmazhajmohammadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would change the offsets to zero and change the temperature dependency values to the metadata.

@dlebauer
Copy link
Member

@craig-willis does this still need to be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants