-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added 3D scanner alignment correction offset #5
base: master
Are you sure you want to change the base?
Conversation
craig-willis
commented
Feb 1, 2017
•
edited
Loading
edited
- Added 3D scanner alignment correction offset per Add 3D Scanner offset to sensor metadata reference-data#74
@solmazhajmohammadi - please review |
delayed because offset is temperature dependent. @solmazhajmohammadi will update with additional data. |
Can someone comment on the magnitude of the temperature sensitivity? Is it a few millimeters? a few centimeters? more? |
@pless The offset goes up to 4-5 cm, See the plot below: |
@solmazhajmohammadi can you please update these values with the fixed numbers we should use in the pipeline? |
Please also add quantitative est. of error + qualitative description of assumptions. Indicate that it is not temp. corrected, and that resulting error is in absolute position rather than any distortion, plus other relevant technical information. |
A fixed number for the offset would be zero, and we can add the offset based on the model explained above. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would change the offsets to zero and change the temperature dependency values to the metadata.
@craig-willis does this still need to be merged? |