-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 3D Scanner offset to sensor metadata #74
Comments
The offset needs to be stored with the date in the metadata. The data can be pulled by date using Clowder if not hard-coded. |
3 values for offset - XYZ. No rotation or anything yet. |
Another value needed if that's possible: unit for voxel in point cloud coordinate system. |
@ZongyangLi Just to confirm, you're asking for a "unit" field with value "voxel" to be added to the 3d scanner metadata? How is this used? |
Also, @ZongyangLi I thought that 'voxel' refers to the cubes that make up a regular array, and that this sensor generates a point cloud in which
Am I missing something? |
@craig-willis @dlebauer May be I am wrong, but to my understanding, a 3d scanner offset means an offset from point cloud coordinate system to gantry coordinate system. When we have the 3d scanner offset and this 'unit transfer value', we are able to map every point to the field. |
@ZongyangLi Now I understand ... I think the documentation section on 'geospatial information' has the transformations that you are looking for (if not, we can ping Yan). |
Pull request: I've posted this to the clowder-dev instance for review: After PR is merged, I'll post to the primary clowder instance. |
Assigning to Solmaz for review. |
@craig-willis Thanks for the update. The offset need to be applied to only one of the scanners. Current offset is for "Top-heading-west" scanner. Can you please specify it in the metadata. Or add the offset for the "Top-heading-east" scanner as well. It should be [0 , 0 ,0 ] |
@craig-willis - can we wrap this issue up? |
Sorry for the delay, lost track of this ticket. I've added a sensor identifier to the alignment_correction_offset and update the PR. |
@ZongyangLi - do you have what you need now? If so, please close this issue |
@rachelshekar I do not have what I need now. |
dependent upon #44 |
Changing this to April milestone since dependent on terraref/computing-pipeline#265 and #44 |
Changing to June; #44 still open |
terraref/sensor-metadata#5 |
@solmazhajmohammadi please provide an update on the temperature measurements |
I uploaded the report here: |
@solmazhajmohammadi - is this for air or box temperature? Is this data final and ready to be put into the data pipeline? What is your opinion on the urgency of this task (ie can it wait for V2 release)? |
More testing needs to be done to determine:
|
Original offset supplied for PR was not correct because temperature plays an important role in the offset. |
@solmazhajmohammadi - please create new issue for temperature correction and close this issue |
@rachelshekar Issue #63 |
Subtask related to #70.
Completion criteria:
The text was updated successfully, but these errors were encountered: