Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 3D Scanner offset to sensor metadata #74

Closed
1 of 2 tasks
craig-willis opened this issue Jan 12, 2017 · 25 comments
Closed
1 of 2 tasks

Add 3D Scanner offset to sensor metadata #74

craig-willis opened this issue Jan 12, 2017 · 25 comments
Assignees

Comments

@craig-willis
Copy link

craig-willis commented Jan 12, 2017

Subtask related to #70.

Completion criteria:

  • Offset information is stored in 3D scanner metadata
  • Reviewed by relevant stakeholder
@ghost
Copy link

ghost commented Jan 12, 2017

The offset needs to be stored with the date in the metadata.

The data can be pulled by date using Clowder if not hard-coded.

@max-zilla
Copy link

3 values for offset - XYZ. No rotation or anything yet.

@ZongyangLi
Copy link

Another value needed if that's possible: unit for voxel in point cloud coordinate system.

@craig-willis craig-willis added this to the January 2017 milestone Jan 12, 2017
@craig-willis
Copy link
Author

@ZongyangLi Just to confirm, you're asking for a "unit" field with value "voxel" to be added to the 3d scanner metadata? How is this used?

@dlebauer
Copy link
Member

dlebauer commented Jan 13, 2017

Also, @ZongyangLi I thought that 'voxel' refers to the cubes that make up a regular array, and that this sensor generates a point cloud in which

  • 'point' implies zero volume and
  • 'cloud' implies that they are not on a regular grid

Am I missing something?

@ZongyangLi
Copy link

@craig-willis @dlebauer
Sorry for the confusion I have generated. When I say 'unit for voxel', I would like to know when point coordinate move from (0,0,0) to (1,1,1), how long is it in each direction in the field(real world).

May be I am wrong, but to my understanding, a 3d scanner offset means an offset from point cloud coordinate system to gantry coordinate system. When we have the 3d scanner offset and this 'unit transfer value', we are able to map every point to the field.

@dlebauer
Copy link
Member

@ZongyangLi Now I understand ... I think the documentation section on 'geospatial information' has the transformations that you are looking for (if not, we can ping Yan).

@craig-willis
Copy link
Author

Pull request:
terraref/sensor-metadata#5

I've posted this to the clowder-dev instance for review:
https://terraref.ncsa.illinois.edu/clowder-dev/api/datasets/58920d9ae4b007e405e03301/metadata.jsonld

After PR is merged, I'll post to the primary clowder instance.

@craig-willis
Copy link
Author

Assigning to Solmaz for review.

@solmazhajmohammadi
Copy link

@craig-willis Thanks for the update. The offset need to be applied to only one of the scanners. Current offset is for "Top-heading-west" scanner. Can you please specify it in the metadata. Or add the offset for the "Top-heading-east" scanner as well. It should be [0 , 0 ,0 ]

@ghost ghost modified the milestones: January 2017, February 2017 Feb 13, 2017
@ghost
Copy link

ghost commented Feb 23, 2017

@craig-willis - can we wrap this issue up?

@craig-willis
Copy link
Author

Sorry for the delay, lost track of this ticket. I've added a sensor identifier to the alignment_correction_offset and update the PR.

@ghost
Copy link

ghost commented Mar 16, 2017

@ZongyangLi - do you have what you need now? If so, please close this issue

@ZongyangLi
Copy link

@rachelshekar I do not have what I need now.

@ghost ghost added the help wanted label Mar 16, 2017
@ghost
Copy link

ghost commented Mar 30, 2017

dependent upon #44

@ghost ghost removed the help wanted label Mar 30, 2017
@ghost
Copy link

ghost commented Apr 4, 2017

Changing this to April milestone since dependent on terraref/computing-pipeline#265 and #44

@ghost ghost modified the milestones: April 2017, February 2017 Apr 4, 2017
@ghost
Copy link

ghost commented May 25, 2017

Changing to June; #44 still open

@ghost ghost modified the milestones: June 2017, April 2017 May 25, 2017
@ghost ghost assigned craig-willis May 25, 2017
@ghost
Copy link

ghost commented May 25, 2017

terraref/sensor-metadata#5
delayed because offset is temperature dependent. @solmazhajmohammadi will update with additional data.

@ghost
Copy link

ghost commented Jul 12, 2017

@solmazhajmohammadi please provide an update on the temperature measurements

@solmazhajmohammadi
Copy link

I uploaded the report here:
3D_Alignment(2).pdf

@ghost
Copy link

ghost commented Jul 20, 2017

@solmazhajmohammadi - is this for air or box temperature? Is this data final and ready to be put into the data pipeline? What is your opinion on the urgency of this task (ie can it wait for V2 release)?

@ghost
Copy link

ghost commented Jul 20, 2017

  • box was not moved when the calibration data was collected
  • temperature is air - weather sensor on top of gantry
  • this affects leaf/tissue level, not plot level

More testing needs to be done to determine:

  • If this offset applies for all sensors
  • If the gantry expanding - eg Is the temperature response different at different ends of the field?

@ghost ghost modified the milestone: June 2017 Jul 20, 2017
@ghost
Copy link

ghost commented Jul 20, 2017

Original offset supplied for PR was not correct because temperature plays an important role in the offset.

@ghost
Copy link

ghost commented Jul 20, 2017

@solmazhajmohammadi - please create new issue for temperature correction and close this issue

@solmazhajmohammadi
Copy link

@rachelshekar Issue #63

@ghost ghost removed this from the June 2017 milestone Aug 3, 2017
@sbrad77 sbrad77 closed this as completed May 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants