Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assisted intaking #68
Assisted intaking #68
Changes from 6 commits
9747f5a
077e170
d4f014f
dc2d856
1cfa0bb
bda0d22
f5cbc3a
5b49878
c7eeccf
c7daab3
ff23aa7
bb6cfda
f929618
6ea9251
be84c19
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this function need to exist? Or should
Swerve.sendSwerveRequest
callgetRobotRelativeAssistSpeeds
when in one of the assist modes? Seems easier to me to just call it in one of the assist states in Swerve.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah most likely the way you want to do this is have a collectInputs in swerve which calculates the intake assist offset (but only when in an intake assist state), stores that in a field, and then adds the offset in
sendSwerveRequest()