Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assisted intaking #68

Merged
merged 15 commits into from
Oct 23, 2024
Merged

Assisted intaking #68

merged 15 commits into from
Oct 23, 2024

Conversation

saikiranra
Copy link
Contributor

@saikiranra saikiranra commented Oct 18, 2024

Opening PR to write comments

Closes #66

@saikiranra saikiranra linked an issue Oct 18, 2024 that may be closed by this pull request
@saikiranra saikiranra removed a link to an issue Oct 18, 2024
Copy link
Contributor Author

@saikiranra saikiranra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to also add button bindings to make sure it only is intake assisting in teleop when holding down the intake button or in auto when a specific intake command is used.

src/main/java/frc/robot/imu/ImuSubsystem.java Show resolved Hide resolved

}

public void updateSwerveSpeeds() {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this function need to exist? Or should Swerve.sendSwerveRequest call getRobotRelativeAssistSpeeds when in one of the assist modes? Seems easier to me to just call it in one of the assist states in Swerve.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah most likely the way you want to do this is have a collectInputs in swerve which calculates the intake assist offset (but only when in an intake assist state), stores that in a field, and then adds the offset in sendSwerveRequest()

@jonahsnider
Copy link
Member

jonahsnider commented Oct 22, 2024

Need to also add button bindings to make sure it only is intake assisting in teleop when holding down the intake button or in auto when a specific intake command is used.

Discussed this a bit with Fernanda last meeting and it seemed like the simplest approach is

  • For teleop, use intake button onTrue for assisted intake, and onFalse for regular intake
  • For auto, the intake event marker will run an intakeAssistRequest(), no special stuff needed there

src/main/java/frc/robot/Robot.java Outdated Show resolved Hide resolved

}

public void updateSwerveSpeeds() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah most likely the way you want to do this is have a collectInputs in swerve which calculates the intake assist offset (but only when in an intake assist state), stores that in a field, and then adds the offset in sendSwerveRequest()

@fcuellar13 fcuellar13 merged commit 12c8446 into main Oct 23, 2024
3 of 6 checks passed
@fcuellar13 fcuellar13 deleted the assisted-intaking branch October 23, 2024 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create intake assist manager
3 participants