-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assisted intaking #68
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to also add button bindings to make sure it only is intake assisting in teleop when holding down the intake button or in auto when a specific intake command is used.
|
||
} | ||
|
||
public void updateSwerveSpeeds() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this function need to exist? Or should Swerve.sendSwerveRequest
call getRobotRelativeAssistSpeeds
when in one of the assist modes? Seems easier to me to just call it in one of the assist states in Swerve.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah most likely the way you want to do this is have a collectInputs in swerve which calculates the intake assist offset (but only when in an intake assist state), stores that in a field, and then adds the offset in sendSwerveRequest()
Discussed this a bit with Fernanda last meeting and it seemed like the simplest approach is
|
Co-authored-by: Jonah Snider <[email protected]>
|
||
} | ||
|
||
public void updateSwerveSpeeds() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah most likely the way you want to do this is have a collectInputs in swerve which calculates the intake assist offset (but only when in an intake assist state), stores that in a field, and then adds the offset in sendSwerveRequest()
Opening PR to write comments
Closes #66