Remove unnecessary drops from storage impls.

[gilbens-starkware]

This change is 

[orizi]

Reviewed 11 of 11 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @gilbens-starkware)

---

corelib/src/starknet/storage.cairo line 266 at r1 (raw file):

    +core::hash::Hash<EntryInfo::<T>::Key, StoragePathHashState>,
    +starknet::Store<EntryInfo::<T>::Value>,
    +Drop<EntryInfo::<T>::Key>,

this doesn't seem required as well.

Code quote:

    +Drop<EntryInfo::<T>::Key>,

---

corelib/src/starknet/storage.cairo line 298 at r1 (raw file):

    +core::hash::Hash<EntryInfo::<MutableTrait::<T>::InnerType>::Key, StoragePathHashState>,
    +starknet::Store<EntryInfo::<MutableTrait::<T>::InnerType>::Value>,
    +Drop<EntryInfo::<MutableTrait::<T>::InnerType>::Key>,

ditto

Code quote:

    +Drop<EntryInfo::<MutableTrait::<T>::InnerType>::Key>,

---

corelib/src/starknet/storage.cairo line 512 at r1 (raw file):

    impl PointerImpl: StorageAsPointer<T>,
    impl AccessImpl: StoragePointerReadAccess<StoragePointer0Offset<PointerImpl::Value>>,
    +Drop<T>,

ditto

Code quote:

    +Drop<T>,

[gilbens-starkware]

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @orizi)

---

corelib/src/starknet/storage.cairo line 266 at r1 (raw file):

Previously, orizi wrote…

this doesn't seem required as well.

It is, the arg key is dropped in case of a panic.

[orizi]

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @gilbens-starkware)

---

corelib/src/starknet/storage.cairo line 266 at r1 (raw file):

Previously, gilbens-starkware (Gil Ben-Shachar) wrote…

It is, the arg key is dropped in case of a panic.

the key is used in the first .entry(key) call.

[gilbens-starkware]

Reviewable status: 0 of 11 files reviewed, 3 unresolved discussions (waiting on @orizi)

---

corelib/src/starknet/storage.cairo line 266 at r1 (raw file):

Previously, orizi wrote…

the key is used in the first .entry(key) call.

You are of course correct. Done

---

corelib/src/starknet/storage.cairo line 298 at r1 (raw file):

Previously, orizi wrote…

ditto

Done.

---

corelib/src/starknet/storage.cairo line 512 at r1 (raw file):

Previously, orizi wrote…

ditto

Done.

[orizi]

Reviewed 2 of 11 files at r2, all commit messages.
Reviewable status: 2 of 11 files reviewed, 1 unresolved discussion (waiting on @gilbens-starkware)

---

corelib/src/starknet/storage.cairo line 512 at r1 (raw file):

Previously, gilbens-starkware (Gil Ben-Shachar) wrote…

Done.

still here.

[gilbens-starkware]

Reviewable status: 0 of 11 files reviewed, 1 unresolved discussion (waiting on @orizi)

---

corelib/src/starknet/storage.cairo line 512 at r1 (raw file):

Previously, orizi wrote…

still here.

Done.

[orizi]

Reviewed 11 of 11 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @gilbens-starkware)