Skip to content

Commit

Permalink
Remove unnecessary drops from storage impls.
Browse files Browse the repository at this point in the history
commit-id:39205511
  • Loading branch information
gilbens-starkware committed Jul 3, 2024
1 parent 53f7a0d commit 3ba8838
Show file tree
Hide file tree
Showing 11 changed files with 87 additions and 90 deletions.
3 changes: 0 additions & 3 deletions corelib/src/starknet/storage.cairo
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,6 @@ impl StorableEntryReadAccess<
+core::hash::Hash<EntryInfo::<T>::Key, StoragePathHashState>,
+starknet::Store<EntryInfo::<T>::Value>,
+Drop<EntryInfo::<T>::Key>,
+Drop<EntryInfo::<T>::Value>
> of StorageMapReadAccessTrait<StoragePath<T>> {
type Key = EntryInfo::<T>::Key;
type Value = EntryInfo::<T>::Value;
Expand Down Expand Up @@ -297,7 +296,6 @@ impl MutableStorableEntryReadAccess<
+core::hash::Hash<EntryInfo::<MutableTrait::<T>::InnerType>::Key, StoragePathHashState>,
+starknet::Store<EntryInfo::<MutableTrait::<T>::InnerType>::Value>,
+Drop<EntryInfo::<MutableTrait::<T>::InnerType>::Key>,
+Drop<EntryInfo::<MutableTrait::<T>::InnerType>::Value>
> of StorageMapReadAccessTrait<StoragePath<T>> {
type Key = EntryInfo::<MutableTrait::<T>::InnerType>::Key;
type Value = EntryInfo::<MutableTrait::<T>::InnerType>::Value;
Expand Down Expand Up @@ -512,7 +510,6 @@ impl StorablePointerReadAccessImpl<
impl PointerImpl: StorageAsPointer<T>,
impl AccessImpl: StoragePointerReadAccess<StoragePointer0Offset<PointerImpl::Value>>,
+Drop<T>,
+Drop<AccessImpl::Value>,
> of StoragePointerReadAccess<T> {
type Value = AccessImpl::Value;
fn read(self: @T) -> Self::Value {
Expand Down

Large diffs are not rendered by default.

18 changes: 9 additions & 9 deletions crates/cairo-lang-starknet/test_data/erc20__erc_20.sierra

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

0 comments on commit 3ba8838

Please sign in to comment.