Skip to content

Commit

Permalink
Remove unnecessary drops from storage impls.
Browse files Browse the repository at this point in the history
commit-id:39205511
  • Loading branch information
gilbens-starkware committed Jul 3, 2024
1 parent 53f7a0d commit 4cc4db7
Show file tree
Hide file tree
Showing 11 changed files with 87 additions and 93 deletions.
6 changes: 0 additions & 6 deletions corelib/src/starknet/storage.cairo
Original file line number Diff line number Diff line change
Expand Up @@ -263,8 +263,6 @@ impl StorableEntryReadAccess<
+EntryInfo<T>,
+core::hash::Hash<EntryInfo::<T>::Key, StoragePathHashState>,
+starknet::Store<EntryInfo::<T>::Value>,
+Drop<EntryInfo::<T>::Key>,
+Drop<EntryInfo::<T>::Value>
> of StorageMapReadAccessTrait<StoragePath<T>> {
type Key = EntryInfo::<T>::Key;
type Value = EntryInfo::<T>::Value;
Expand Down Expand Up @@ -296,8 +294,6 @@ impl MutableStorableEntryReadAccess<
+EntryInfo<MutableTrait::<T>::InnerType>,
+core::hash::Hash<EntryInfo::<MutableTrait::<T>::InnerType>::Key, StoragePathHashState>,
+starknet::Store<EntryInfo::<MutableTrait::<T>::InnerType>::Value>,
+Drop<EntryInfo::<MutableTrait::<T>::InnerType>::Key>,
+Drop<EntryInfo::<MutableTrait::<T>::InnerType>::Value>
> of StorageMapReadAccessTrait<StoragePath<T>> {
type Key = EntryInfo::<MutableTrait::<T>::InnerType>::Key;
type Value = EntryInfo::<MutableTrait::<T>::InnerType>::Value;
Expand All @@ -318,7 +314,6 @@ impl MutableStorableEntryWriteAccess<
+EntryInfo<MutableTrait::<T>::InnerType>,
+core::hash::Hash<EntryInfo::<MutableTrait::<T>::InnerType>::Key, StoragePathHashState>,
+starknet::Store<EntryInfo::<MutableTrait::<T>::InnerType>::Value>,
+Drop<EntryInfo::<MutableTrait::<T>::InnerType>::Key>,
+Drop<EntryInfo::<MutableTrait::<T>::InnerType>::Value>
> of StorageMapWriteAccessTrait<StoragePath<T>> {
type Key = EntryInfo::<MutableTrait::<T>::InnerType>::Key;
Expand Down Expand Up @@ -512,7 +507,6 @@ impl StorablePointerReadAccessImpl<
impl PointerImpl: StorageAsPointer<T>,
impl AccessImpl: StoragePointerReadAccess<StoragePointer0Offset<PointerImpl::Value>>,
+Drop<T>,
+Drop<AccessImpl::Value>,
> of StoragePointerReadAccess<T> {
type Value = AccessImpl::Value;
fn read(self: @T) -> Self::Value {
Expand Down

Large diffs are not rendered by default.

18 changes: 9 additions & 9 deletions crates/cairo-lang-starknet/test_data/erc20__erc_20.sierra

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

0 comments on commit 4cc4db7

Please sign in to comment.