Support specifying externalTrafficPolicy in Services created by listener-operator #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbernauer
force-pushed
the
feat/listener-service-external-traffic-policy
branch
from
d6dde1f
to
ec74d04
Compare
nightkr
previously approved these changes
Aug 7, 2023
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -35,6 +35,38 @@ pub enum ServiceType { | |||
| ClusterIP, | |||
| } | |||
|
|
|||
| impl ServiceType { | |||
| pub fn to_kubernetes_literal(&self) -> String { | |||
| match self { | |||
There was a problem hiding this comment.
🚫 [clippy] reported by reviewdog 🐶
error[E0004]: non-exhaustive patterns: `&commons::listener::ServiceType::ClusterIP` not covered
--> src/commons/listener.rs:40:15
|
40 | match self {
| ^^^^ pattern `&commons::listener::ServiceType::ClusterIP` not covered
|
note: `commons::listener::ServiceType` defined here
--> src/commons/listener.rs:35:5
|
29 | pub enum ServiceType {
| -----------
...
35 | ClusterIP,
| ^^^^^^^^^ not covered
= note: the matched value is of type `&commons::listener::ServiceType`
help: ensure that all possible cases are being handled by adding a match arm with a wildcard pattern or an explicit pattern as shown
|
42 ~ ServiceType::LoadBalancer => "LoadBalancer".to_string(),
43 ~ &commons::listener::ServiceType::ClusterIP => todo!(),
|
| @@ -35,6 +35,38 @@ pub enum ServiceType { | |||
| ClusterIP, | |||
| } | |||
|
|
|||
| impl ServiceType { | |||
| pub fn to_kubernetes_literal(&self) -> String { | |||
| match self { | |||
There was a problem hiding this comment.
🚫 [clippy] reported by reviewdog 🐶
error[E0004]: non-exhaustive patterns: `&commons::listener::ServiceType::ClusterIP` not covered
--> src/commons/listener.rs:40:15
|
40 | match self {
| ^^^^ pattern `&commons::listener::ServiceType::ClusterIP` not covered
|
note: `commons::listener::ServiceType` defined here
--> src/commons/listener.rs:35:5
|
29 | pub enum ServiceType {
| -----------
...
35 | ClusterIP,
| ^^^^^^^^^ not covered
= note: the matched value is of type `&commons::listener::ServiceType`
help: ensure that all possible cases are being handled by adding a match arm with a wildcard pattern or an explicit pattern as shown
|
42 ~ ServiceType::LoadBalancer => "LoadBalancer".to_string(),
43 ~ &commons::listener::ServiceType::ClusterIP => todo!(),
|
|
Superseded by #773 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Needed by stackabletech/listener-operator#57
Review Checklist
Once the review is done, comment
bors r+(orbors merge) to merge. Further information