Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support specifying externalTrafficPolicy in Services created by listener-operator #57

Closed
wants to merge 1 commit into from
Closed

Support specifying externalTrafficPolicy in Services created by listener-operator #57

wants to merge 1 commit into from

Conversation

sbernauer
Copy link
Member

@sbernauer sbernauer commented Mar 5, 2023 •
edited
Loading

Description

Needs stackabletech/operator-rs#562

Review Checklist

  • Code contains useful comments
  • CRD change approved (or not applicable)
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)
  • Helm chart can be installed and deployed operator works (or not applicable)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

sbernauer
sbernauer commented Mar 5, 2023
View reviewed changes
Cargo.toml Show resolved Hide resolved
This was referenced May 6, 2024
Closed
Merged
@sbernauer
Copy link
Member Author

Tried to implement it and noticed we already did that in #196

@sbernauer sbernauer closed this Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nightkr nightkr nightkr left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbernauer @nightkr