-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support specifying externalTrafficPolicy in Services created by listener-operator #562
Closed
Closed
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -35,6 +35,38 @@ pub enum ServiceType { | |
ClusterIP, | ||
} | ||
|
||
impl ServiceType { | ||
pub fn to_kubernetes_literal(&self) -> String { | ||
match self { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🚫 [clippy] reported by reviewdog 🐶
|
||
ServiceType::NodePort => "NodePort".to_string(), | ||
ServiceType::LoadBalancer => "LoadBalancer".to_string(), | ||
} | ||
} | ||
} | ||
|
||
#[derive(Serialize, Deserialize, Clone, Debug, JsonSchema, PartialEq, Eq)] | ||
pub enum TrafficPolicy { | ||
/// Obscures the client source IP and may cause a second hop to another node, but allows Kubernetes to spread the load between all nodes. | ||
Cluster, | ||
/// Preserves the client source IP and avoid a second hop for LoadBalancer and NodePort type Services, but makes clients responsible for spreading the load. | ||
Local, | ||
} | ||
|
||
impl Default for TrafficPolicy { | ||
fn default() -> Self { | ||
TrafficPolicy::Cluster | ||
} | ||
} | ||
|
||
impl TrafficPolicy { | ||
pub fn to_kubernetes_literal(&self) -> String { | ||
match self { | ||
TrafficPolicy::Cluster => "Cluster".to_string(), | ||
TrafficPolicy::Local => "Local".to_string(), | ||
} | ||
} | ||
} | ||
|
||
/// Exposes a set of pods to the outside world. | ||
/// | ||
/// Essentially a Stackable extension of a Kubernetes [`Service`]. Compared to [`Service`], [`Listener`] changes two things: | ||
|
@@ -61,6 +93,9 @@ pub struct ListenerSpec { | |
/// Whether incoming traffic should also be directed to `Pod`s that are not `Ready`. | ||
#[schemars(default = "Self::default_publish_not_ready_addresses")] | ||
pub publish_not_ready_addresses: Option<bool>, | ||
/// `externalTrafficPolicy` that should be set on the [`Service`] object. | ||
#[serde(default)] | ||
pub service_external_traffic_policy: TrafficPolicy, | ||
} | ||
|
||
impl ListenerSpec { | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [clippy] reported by reviewdog 🐶