-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds flags for ACU checking to hwp supervisor, along with tests #802
Open
jlashner
wants to merge
29
commits into
main
Choose a base branch
from
hwp-flags-for-acu
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+808
−75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
jlashner
force-pushed
the
hwp-flags-for-acu
branch
from
December 16, 2024 21:02
461566b
to
0498c71
Compare
for more information, see https://pre-commit.ci
jlashner
force-pushed
the
hwp-flags-for-acu
branch
from
December 16, 2024 22:25
08854be
to
cd0d427
Compare
jlashner
force-pushed
the
hwp-flags-for-acu
branch
from
December 17, 2024 21:56
d2ebe65
to
143e679
Compare
jlashner
force-pushed
the
hwp-flags-for-acu
branch
from
December 17, 2024 22:23
55a273f
to
bce28e8
Compare
jlashner
force-pushed
the
hwp-flags-for-acu
branch
from
December 18, 2024 01:10
7feffe5
to
44196c0
Compare
jlashner
force-pushed
the
hwp-flags-for-acu
branch
from
December 18, 2024 04:32
aa77700
to
e355b34
Compare
jlashner
force-pushed
the
hwp-flags-for-acu
branch
from
December 18, 2024 19:41
363ea46
to
7aa2fcc
Compare
jlashner
force-pushed
the
hwp-flags-for-acu
branch
from
December 18, 2024 19:45
6837f47
to
100d412
Compare
jlashner
force-pushed
the
hwp-flags-for-acu
branch
from
December 18, 2024 20:26
1742336
to
85db2c5
Compare
jlashner
force-pushed
the
hwp-flags-for-acu
branch
from
December 18, 2024 20:38
4b6f71a
to
d8adce5
Compare
jlashner
force-pushed
the
hwp-flags-for-acu
branch
from
December 18, 2024 20:59
bb0343d
to
0e5f9f2
Compare
for more information, see https://pre-commit.ci
6 tasks
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
@BrianJKoopman Ended up getting the tests to work properly! Turns out I missed a shutdown call for one of the device_emulators in the hwp emulator. Adding that makes tests clean up correctly, so I reverted the misc changes I made to test the github workflow. This contains the same update to the HWP supervisor as #805, so if you'd rather just review and merge this one we can close the other one. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
This adds gripper-state monitoring to the HWP
monitor
process, and adds the following flags to the HWP state which can be checked by the ACU:gripper_state
which can be "cold", "warm", "ungripped", or "unknown"is_spinning
booleanHow Has This Been Tested?
Along with these changes, I am building out the HWP emulator into a set of integration tests that test the behavior of these flags and other operations.
This has been tested with HWP and ACU hardware on satp1.
Types of changes
Checklist: