Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use target include directories #1040

Merged
merged 3 commits into from
Jun 19, 2020
Merged

use target include directories #1040

merged 3 commits into from
Jun 19, 2020

Conversation

Karsten1987
Copy link

as per comment. Same as ros-perception/laser_geometry#53

Signed-off-by: Karsten Knese [email protected]

@Karsten1987
use target include directories
1dcbafa 
Signed-off-by: Karsten Knese <[email protected]>
@Karsten1987 Karsten1987 requested a review from chapulina February 5, 2020 23:20
@chapulina chapulina added the ros2 label Feb 6, 2020
@Karsten1987 Karsten1987 changed the base branch from ros2 to eloquent February 6, 2020 00:30
@Karsten1987 Karsten1987 changed the base branch from eloquent to ros2 February 6, 2020 03:18
@Karsten1987
Copy link
Author

as discussed, changing the base branch back to ros2 as this is targeted for foxy.

@chapulina
Copy link
Contributor

Foxy CI: Build Status

@chapulina
Copy link
Contributor

@ros-pull-request-builder retest this please

1 similar comment
@chapulina
Copy link
Contributor

@ros-pull-request-builder retest this please

chapulina
chapulina approved these changes Jun 19, 2020
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compiles fine, the test failures are already happening on ros2.

@chapulina chapulina merged commit aa18d71 into ros-simulation:ros2 Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

Assignees
No one assigned
Labels
ros2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Karsten1987 @chapulina