-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create doc file for chained controllers #985
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #985 +/- ##
==========================================
- Coverage 34.61% 32.69% -1.93%
==========================================
Files 52 91 +39
Lines 2981 9551 +6570
Branches 1855 6432 +4577
==========================================
+ Hits 1032 3123 +2091
- Misses 310 704 +394
- Partials 1639 5724 +4085
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Are you happy with me merging this? People want some docs, this is better than nothing! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope this gets merged soon ;)
At least a proper rst markup + pictures and link the file to the docs is needed. (Silently advertising ros-controls/control.ros.org#125).
Or: Push this file as .md file where the suggested changes are accepted, and I could do the translation to rst then.
@christophfroehlich could we try the docs on this PR? |
this is no valid rst syntax. i'll make an PR against this PR with the changes this weekend |
Ah yeah I'm aware of that :D was just wondering how far it is. But agree that this should be merged asap |
I refactored it with PR #1068 |
* Refactor doc for rst syntax * Add chaining controllers to toc * fix typo --------- Co-authored-by: Bence Magyar <[email protected]>
@bmagyar this hasn't been backported to humble, which caused the conflict with #1106. The image and the link in doc/index.rst is missing, see this error. |
@destogl can this be backported to humble to fix the build error with the docs for humble? |
Co-authored-by: Bence Magyar <[email protected]> Co-authored-by: Christoph Fröhlich <[email protected]> (cherry picked from commit 185fbea) # Conflicts: # controller_manager/doc/controller_chaining.rst
We have to fix this. The docs is very wrong and misleading in few places... |
No description provided.