-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update initial_value parameters of generic_system tests #1943
Update initial_value parameters of generic_system tests #1943
Conversation
This pull request is in conflict. Could you fix it @kumar-sanjeeev? |
@kumar-sanjeeev, all pull requests must be targeted towards the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! I changed the base branch to humble, it seems that you have forgotten to change the default.
When you commit another time, the checks will be triggered hopefully.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## humble #1943 +/- ##
==========================================
+ Coverage 62.58% 62.89% +0.31%
==========================================
Files 108 109 +1
Lines 12026 12494 +468
Branches 8133 8481 +348
==========================================
+ Hits 7526 7858 +332
+ Misses 880 852 -28
- Partials 3620 3784 +164
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, there are no more deprecation warnings in the logs!
I don't think that we would need
<state_interface name="velocity">
<param name="initial_value">0.0</param>
</state_interface>
<state_interface name="acceleration">
<param name="initial_value">0.0</param>
</state_interface>
everywhere, at least it isn't done in #1150
This will only make a difference if calculate_dynamics
is true
Okay to be consistence with #1150, I will also remove them from here. |
d7fcbca
into
ros-controls:humble
print_hint
tofalse
to suppress warnings when no initial value is provided.