Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update initial_value parameters of generic_system tests #1943

Merged
merged 6 commits into from
Dec 17, 2024

Conversation

kumar-sanjeeev
Copy link
Contributor

  • Add initial values for every state interface in the ros2_control.xacro.
  • Update print_hint to false to suppress warnings when no initial value is provided.

Copy link
Contributor

mergify bot commented Dec 15, 2024

This pull request is in conflict. Could you fix it @kumar-sanjeeev?

@christophfroehlich christophfroehlich changed the base branch from master to humble December 15, 2024 21:50
Copy link
Contributor

mergify bot commented Dec 15, 2024

@kumar-sanjeeev, all pull requests must be targeted towards the master development branch.
Once merged into master, it is possible to backport to humble, but it must be in master
to have these changes reflected into new distributions.

Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I changed the base branch to humble, it seems that you have forgotten to change the default.
When you commit another time, the checks will be triggered hopefully.

hardware_interface/src/mock_components/generic_system.cpp Outdated Show resolved Hide resolved
hardware_interface/src/mock_components/generic_system.cpp Outdated Show resolved Hide resolved
@christophfroehlich christophfroehlich linked an issue Dec 15, 2024 that may be closed by this pull request
8 tasks
@christophfroehlich christophfroehlich changed the title Fix issue#1931 Update initial_value parameters of generic_system tests Dec 15, 2024
Copy link

codecov bot commented Dec 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.89%. Comparing base (d897740) to head (1c0ceb8).
Report is 30 commits behind head on humble.

Additional details and impacted files
@@            Coverage Diff             @@
##           humble    #1943      +/-   ##
==========================================
+ Coverage   62.58%   62.89%   +0.31%     
==========================================
  Files         108      109       +1     
  Lines       12026    12494     +468     
  Branches     8133     8481     +348     
==========================================
+ Hits         7526     7858     +332     
+ Misses        880      852      -28     
- Partials     3620     3784     +164     
Flag Coverage Δ
unittests 62.89% <ø> (+0.31%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...e_interface/src/mock_components/generic_system.cpp 77.37% <ø> (-2.63%) ⬇️
...rface/test/mock_components/test_generic_system.cpp 36.53% <ø> (ø)

... and 3 files with indirect coverage changes

Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, there are no more deprecation warnings in the logs!

I don't think that we would need

      <state_interface name="velocity">
        <param name="initial_value">0.0</param>
      </state_interface>
      <state_interface name="acceleration">
        <param name="initial_value">0.0</param>
      </state_interface>

everywhere, at least it isn't done in #1150
This will only make a difference if calculate_dynamics is true

@kumar-sanjeeev
Copy link
Contributor Author

LGTM, there are no more deprecation warnings in the logs!

I don't think that we would need

      <state_interface name="velocity">
        <param name="initial_value">0.0</param>
      </state_interface>
      <state_interface name="acceleration">
        <param name="initial_value">0.0</param>
      </state_interface>

everywhere, at least it isn't done in #1150 This will only make a difference if calculate_dynamics is true

Okay to be consistence with #1150, I will also remove them from here.

@christophfroehlich christophfroehlich merged commit d7fcbca into ros-controls:humble Dec 17, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mock_generic_system tests on humble use deprecated format
3 participants