-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add service call timeout argument in spawner (backport #1808) #1886
Conversation
Cherry-pick of 41d7393 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
--------- Signed-off-by: Angsa Deployment Team <[email protected]> Signed-off-by: Tony Najjar <[email protected]> Co-authored-by: Angsa Deployment Team <[email protected]> Co-authored-by: Christoph Fröhlich <[email protected]> Co-authored-by: Sai Kishor Kothakota <[email protected]>
0372e6d
to
efb323a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## humble #1886 +/- ##
==========================================
- Coverage 62.95% 62.93% -0.02%
==========================================
Files 109 109
Lines 12493 12495 +2
Branches 8481 8480 -1
==========================================
- Hits 7865 7864 -1
- Misses 845 847 +2
- Partials 3783 3784 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This pull request is in conflict. Could you fix it @bmagyar @destogl @christophfroehlich @saikishor? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR exposes the call_timeout of the spawner to be optionally set by the user
This is an automatic backport of pull request #1808 done by Mergify.