Add few warning compiler options to error (backport #1181)

[mergify]

Inspiring from the PRs that @destogl made recently: #1173 & #1174. I think it is in the best interest of everyone to add some compiler flags to errors to better code quality. I have done it for the most important packages and fixed some errors at the same time

---

This is an automatic backport of pull request #1181 done by Mergify.

[mergify]

Cherry-pick of 65353ff has failed:

On branch mergify/bp/iron/pr-1181
Your branch is up to date with 'origin/iron'.

You are currently cherry-picking commit 65353ff.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   controller_interface/CMakeLists.txt
	modified:   controller_manager/CMakeLists.txt
	modified:   hardware_interface/CMakeLists.txt
	modified:   hardware_interface/src/mock_components/generic_system.cpp
	modified:   joint_limits/CMakeLists.txt
	modified:   transmission_interface/CMakeLists.txt

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   controller_manager/src/controller_manager.cpp
	both modified:   hardware_interface_testing/test/test_resource_manager.cpp

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

[christophfroehlich]

This fixes #1589 locally for me (don't ask me why).

[saikishor]

@christophfroehlich I'm not sure if this should be with -1 or +1

[christophfroehlich]

I copied that from here, why do we expect a different value here? and yes, the tests fail..

[saikishor]

This fixes #1589 locally for me (don't ask me why).

Could be from shadow variables?

BTW the tests are failing in the jobs

[christophfroehlich]

This fixes #1589 locally for me (don't ask me why).

Could be from shadow variables?

No, something with doxygen.

[christophfroehlich]

better not fight a soon EOL distro ;)