Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Backport #1636 #1668 and fix coverage on jammy #1677

Merged
merged 5 commits into from
Aug 15, 2024
Merged

Conversation

christophfroehlich
Copy link
Contributor

@christophfroehlich christophfroehlich commented Aug 14, 2024

Backport #1636 #1668 and fix coverage on jammy

@christophfroehlich christophfroehlich changed the base branch from master to humble August 14, 2024 12:27
Copy link

codecov bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.23%. Comparing base (c04a16f) to head (6d6eea3).
Report is 17 commits behind head on humble.

Additional details and impacted files
@@             Coverage Diff             @@
##           humble    #1677       +/-   ##
===========================================
- Coverage   87.00%   62.23%   -24.78%     
===========================================
  Files          97      105        +8     
  Lines        7505    11122     +3617     
  Branches      677     7778     +7101     
===========================================
+ Hits         6530     6922      +392     
- Misses        688      809      +121     
- Partials      287     3391     +3104     
Flag Coverage Δ
unittests 62.23% <100.00%> (-24.78%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ller_manager/test/test_ros2_control_node_launch.py 100.00% <100.00%> (ø)
controller_manager/test/test_spawner_unspawner.cpp 59.29% <100.00%> (-39.17%) ⬇️

... and 69 files with indirect coverage changes

@christophfroehlich christophfroehlich changed the title Fix coverage on jammy [CI] Backport #1636 #1668 and fix coverage on jammy Aug 14, 2024
@christophfroehlich christophfroehlich marked this pull request as ready for review August 14, 2024 20:27
@destogl destogl merged commit 8b32c33 into humble Aug 15, 2024
11 of 12 checks passed
@destogl destogl deleted the test_coverage branch August 15, 2024 18:53
@christophfroehlich
Copy link
Contributor Author

@Mergifyio backport iron

Copy link
Contributor

mergify bot commented Aug 19, 2024

backport iron

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Aug 19, 2024
* Add a pytest launch file to test ros2_control_node (#1636)
* [CI] Add coveragepy and remove ignore: test (#1668)

(cherry picked from commit 8b32c33)
christophfroehlich added a commit that referenced this pull request Aug 19, 2024
* Add a pytest launch file to test ros2_control_node (#1636)
* [CI] Add coveragepy and remove ignore: test (#1668)

(cherry picked from commit 8b32c33)

Co-authored-by: Christoph Fröhlich <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants