-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add joint limiter interface plugins to enforce limits defined in the URDF #1526
base: master
Are you sure you want to change the base?
Add joint limiter interface plugins to enforce limits defined in the URDF #1526
Conversation
This pull request is in conflict. Could you fix it @saikishor? |
This pull request is in conflict. Could you fix it @saikishor? |
61a0949
to
876a52c
Compare
This pull request is in conflict. Could you fix it @saikishor? |
82107d2
to
7b6c4ff
Compare
c4da2d0
to
f088099
Compare
f088099
to
51a69af
Compare
@@ -70,55 +70,58 @@ class JointLimiterInterface | |||
// TODO(destogl): get limits from URDF |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is not needed anymore. Am I right? Do we want to get here limits from URDF? This might make sense to parse URDF limits also in the controller if this are required.
1d96350
to
2f91440
Compare
…rfacesData> and enforce hard limtis
Co-authored-by: Bence Magyar <[email protected]>
7cb29df
to
296f992
Compare
This PR includes the changes of the PR from @destogl #971, and on top of that it extends the proposed methods to be able to integrate and be able to provide an interface that will allow enforcing the joint limits in position, velocity, effort, acceleration, etc. The proposed interface can accept different types of data in the enforce methods with the help of templating and this can be helpful to extend to different applications in the future.
This PR is done as a part of #1466 to be able to integrate the limiters within the
ResourceManager
Closes #971