[BREAKING CHANGE] Use robot_description topic instead of ~/robot_description and update docs regarding this
#1410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nowadays the parameter is deprecated and will get removed.
Using robot_description by default instead will work for most people out of the box while also working correctly with different descriptions in different namespaces when using remaps.
github-actions
bot
requested review from
bijoua29,
bmagyar,
destogl,
erickisos,
jaron-l,
olivier-stasse and
VX792
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1410 +/- ##
===========================================
+ Coverage 0 75.88% +75.88%
===========================================
Files 0 41 +41
Lines 0 3359 +3359
Branches 0 1935 +1935
===========================================
+ Hits 0 2549 +2549
- Misses 0 418 +418
- Partials 0 392 +392
Flags with carried forward coverage won't be shown. Click here to find out more.
|
christophfroehlich
previously approved these changes
Feb 22, 2024
saikishor
requested changes
Feb 22, 2024
Co-authored-by: Sai Kishor Kothakota <[email protected]>
saikishor
requested changes
Feb 22, 2024
Co-authored-by: Sai Kishor Kothakota <[email protected]>
Co-authored-by: Sai Kishor Kothakota <[email protected]>
|
@fmauch Can you fix the format locally and push?, apart from that everything looks good to me |
|
Yes, but not before tonight |
|
Found a short slot. |
christophfroehlich
approved these changes
Feb 22, 2024
destogl
approved these changes
Feb 28, 2024
|
Please backport to humble |
Unfortunately, we cannot backport this to the Humble LTS distro, it would break lots of existing setups. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since now the desired way of receiving the
robot_descriptionis the topic rather than the parameter, we need to update the documentation accordingly as mentioned in #1045 (comment).As discussed in #1358 (comment) and #1138 I've used the
robot_descriptiontopic as this is where we want it to be rather than~/robot_description.To make this correct, I've also added a commit changing the subscription from
~/robot_descriptiontorobot_descriptionwhich is why this is a behavior breaking change. If we merge this here, we then can update #1358 accordingly (I can make a separate PR to that branch, if you like @destogl)