Added parameterized test for spawner.py #1160
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
bijoua29,
bmagyar,
destogl,
erickisos,
rosterloh and
VX792
This was referenced Nov 9, 2023
|
Thank you! Let's see the CIs opinion :) |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1160 +/- ##
=======================================
Coverage 47.63% 47.63%
=======================================
Files 40 40
Lines 3445 3445
Branches 1866 1866
=======================================
Hits 1641 1641
Misses 480 480
Partials 1324 1324
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
@bmagyar could you have a look:) CI was failing but should hopefully be fixed now. |
bmagyar
changed the title
|
Pretty happy with how this looks. Time to add a few more instantiations to that parametrized test now! :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding #964.
Replacement of pull request #1152.
This time I used parameterised tests. As always, welcome feedback.
If this approach is approved, I will test all arguments of the spawner, this way.