Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize list hardware components output and code for better readability. #1060

Merged
merged 3 commits into from
Jun 20, 2023
Merged

Optimize list hardware components output and code for better readability. #1060

merged 3 commits into from
Jun 20, 2023

Conversation

destogl
Copy link
Member

@destogl destogl commented Jun 17, 2023 •
edited
Loading

Before

Hardware Component 0
    name: sr-bot
    type: system
    plugin name: mock_components/GenericSystem
    state: id=1 label=unconfigured
    command interfaces
         joint_a1/position [unavailable] [unclaimed]
         joint_a2/position [unavailable] [unclaimed]
         joint_a3/position [unavailable] [unclaimed]
         joint_a4/position [unavailable] [unclaimed]
         joint_a5/position [unavailable] [unclaimed]
         joint_a6/position [unavailable] [unclaimed]

After

Hardware Component 1
    name: sr-bot
    type: system
    plugin name: mock_components/GenericSystem
    state: id=1 label=unconfigured
    command interfaces
         joint_a1/position [unavailable] [unclaimed]
         joint_a2/position [unavailable] [unclaimed]
         joint_a3/position [unavailable] [unclaimed]
         joint_a4/position [unavailable] [unclaimed]
         joint_a5/position [unavailable] [unclaimed]
         joint_a6/position [unavailable] [unclaimed]

Other changes are code readibility.

@destogl destogl self-assigned this Jun 17, 2023
@destogl destogl requested a review from bmagyar June 17, 2023 18:49
destogl added a commit that referenced this pull request Jun 17, 2023
@destogl
Optimize list hardware componets output and code for better readabili…
246a81a 
…ty. (backport #1060)
@destogl destogl mentioned this pull request Jun 17, 2023
Merged
@bmagyar
Copy link
Member

bmagyar commented Jun 17, 2023

Please provide a before / after comparison in the description

@bmagyar bmagyar changed the title Optimize list hardware componets output and code for better readability. Optimize list hardware components output and code for better readability. Jun 17, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #1060 (f66be7b) into master (925f5f3) will decrease coverage by 2.26%.
The diff coverage is 35.14%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #1060      +/-   ##
==========================================
- Coverage   34.61%   32.36%   -2.26%     
==========================================
  Files          52       93      +41     
  Lines        2981     9795    +6814     
  Branches     1855     6599    +4744     
==========================================
+ Hits         1032     3170    +2138     
- Misses        310      777     +467     
- Partials     1639     5848    +4209
Flag Coverage Δ
unittests 32.36% <35.14%> (-2.26%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
controller_manager/src/controller_manager.cpp 38.04% <ø> (-1.67%) ⬇️
controller_manager/src/ros2_control_node.cpp 0.00% <0.00%> (ø)
..._interface/include/hardware_interface/actuator.hpp 100.00% <ø> (ø)
...ce/include/hardware_interface/async_components.hpp 0.00% <0.00%> (ø)
...re_interface/include/hardware_interface/sensor.hpp 100.00% <ø> (ø)
...re_interface/include/hardware_interface/system.hpp 100.00% <ø> (ø)
hardware_interface/src/resource_manager.cpp 47.32% <ø> (-6.30%) ⬇️
hardware_interface/src/sensor.cpp 50.52% <ø> (ø)
hardware_interface/src/system.cpp 55.45% <ø> (ø)
...rface/test/mock_components/test_generic_system.cpp 9.42% <ø> (ø)
... and 70 more

... and 19 files with indirect coverage changes

destogl added a commit to StoglRobotics-forks/ros2_control that referenced this pull request Jun 17, 2023
@destogl
Optimize list hardware componets output and code for better readabili…
c26f89f 
…ty. (backport ros-controls#1060)
bmagyar
bmagyar previously approved these changes Jun 17, 2023
View reviewed changes
Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@bmagyar bmagyar merged commit e14497e into master Jun 20, 2023
1 check passed
bmagyar pushed a commit that referenced this pull request Jun 20, 2023
@destogl
Improve list hardware components output and code for better readabili…
5504b6a 
…ty. (backport #1060) (#1061)
@bmagyar
Copy link
Member

bmagyar commented Jun 23, 2023

@Mergifyio backport humble

@mergify
Copy link
Contributor

mergify bot commented Jun 23, 2023 •
edited
Loading

backport humble

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jun 23, 2023
@destogl @mergify
Improve list hardware components output and code for better readabili…
8474658 
…ty. (#1060)

(cherry picked from commit e14497e)

# Conflicts:
#	ros2controlcli/ros2controlcli/verb/list_hardware_components.py
@mergify mergify bot mentioned this pull request Jun 23, 2023
Closed
flochre pushed a commit to flochre/ros2_control that referenced this pull request Jul 5, 2023
@destogl @flochre
Improve list hardware components output and code for better readabili…
24eae44 
…ty. (backport ros-controls#1060) (ros-controls#1061)
@bmagyar bmagyar deleted the opt-list-hw-comp branch December 4, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aprotyas aprotyas aprotyas approved these changes

@bmagyar bmagyar bmagyar left review comments

@bijoua29 bijoua29 Awaiting requested review from bijoua29

@harderthan harderthan Awaiting requested review from harderthan

@jackcenter jackcenter Awaiting requested review from jackcenter

@LukasMacha97 LukasMacha97 Awaiting requested review from LukasMacha97

Assignees

@destogl destogl

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@destogl @bmagyar @codecov-commenter @aprotyas