-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable ReflowComments to also use ColumnLimit on comments #1037
enable ReflowComments to also use ColumnLimit on comments #1037
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the changes, but now someone has to reformat this repo ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #1037 +/- ##
==========================================
- Coverage 34.61% 32.45% -2.17%
==========================================
Files 52 92 +40
Lines 2981 9681 +6700
Branches 1855 6511 +4656
==========================================
+ Hits 1032 3142 +2110
- Misses 310 772 +462
- Partials 1639 5767 +4128
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Currently, as the ReflowComments are not enabled, the 100 columns limit is only applied to the code but not to the comments, and in the end, the CI checks are failing in this regard. By enabling the ReflowComments, this should be solved