[MockHardware] Use consequently 'mock' instead of 'fake'. #1026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
arne48,
bmagyar,
DasRoteSkelett,
livanov93,
sgmurray and
VanshGehlot
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #1026 +/- ##
==========================================
- Coverage 34.61% 32.71% -1.91%
==========================================
Files 52 91 +39
Lines 2981 9567 +6586
Branches 1855 6441 +4586
==========================================
+ Hits 1032 3130 +2098
- Misses 310 705 +395
- Partials 1639 5732 +4093
Flags with carried forward coverage won't be shown. Click here to find out more.
|
christophfroehlich
approved these changes
May 17, 2023
arne48
approved these changes
May 19, 2023
bmagyar
approved these changes
May 19, 2023
destogl
added
the
backport-humble
mergify bot
pushed a commit
that referenced
this pull request
Jun 5, 2023
(cherry picked from commit 7174a1d) # Conflicts: # hardware_interface/include/mock_components/generic_system.hpp # hardware_interface/src/mock_components/generic_system.cpp # hardware_interface/test/mock_components/test_generic_system.cpp
destogl
added a commit
that referenced
this pull request
Jun 7, 2023
…1026) – And deprecate parameters. (#1051) * Use consequently 'mock' instead of 'fake'. (#1026) (cherry picked from commit 7174a1d) # Conflicts: # hardware_interface/include/mock_components/generic_system.hpp # hardware_interface/src/mock_components/generic_system.cpp # hardware_interface/test/mock_components/test_generic_system.cpp --------- Co-authored-by: Dr. Denis <[email protected]>
flochre
pushed a commit
to flochre/ros2_control
that referenced
this pull request
Jul 5, 2023
…os-controls#1026) – And deprecate parameters. (ros-controls#1051) * Use consequently 'mock' instead of 'fake'. (ros-controls#1026) (cherry picked from commit 7174a1d) # Conflicts: # hardware_interface/include/mock_components/generic_system.hpp # hardware_interface/src/mock_components/generic_system.cpp # hardware_interface/test/mock_components/test_generic_system.cpp --------- Co-authored-by: Dr. Denis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now use consequntly mock instead of fake.