Do not explode with empty tag #1008
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
aprotyas,
destogl,
erickisos,
jackcenter,
LukasMacha97 and
VanshGehlot
|
Dear Sir, in so many hours, you could also add a test for it. |
fmauch
reviewed
May 4, 2023
| @@ -68,7 +69,8 @@ std::string get_text_for_element( | |||
| const auto get_text_output = element_it->GetText(); | |||
| if (!get_text_output) | |||
| { | |||
| throw std::runtime_error("text not specified in the " + tag_name + " tag"); | |||
| std::cerr << "text not specified in the " << tag_name << " tag" << std::endl; | |||
There was a problem hiding this comment.
I did not open a PR in the first place, since the desired behavior wasn't obvious to me. Is this to be considered a non-expected situation (as printing to std::err still suggests)?
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After many hours of work, I've finally implemented a solution for #994