Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix verbose output of list_hardware_components #1004

Merged
merged 1 commit into from
Apr 29, 2023

Conversation

christophfroehlich
Copy link
Contributor

Fixes #999. Additionally, claimed state of state interfaces is always false -> removed output.

Using ros2_control_demo_example_4:

Before

$ ros2 control list_hardware_components -v
Hardware Component 0
        name: RRBotSystemWithSensor
        type: system
        plugin name: ros2_control_demo_example_4/RRBotSystemWithSensorHardware
        state: id=3 label=active
        command interfaces
                joint1/position [available] [claimed]
                joint2/position [available] [claimed]
        state interfaces
                joint1/position [available] [claimed]
                joint2/position [available] [claimed]

After

$ ros2 control list_hardware_components -v
Hardware Component 0
        name: RRBotSystemWithSensor
        type: system
        plugin name: ros2_control_demo_example_4/RRBotSystemWithSensorHardware
        state: id=3 label=active
        command interfaces
                joint1/position [available] [claimed]
                joint2/position [available] [claimed]
        state interfaces
                joint1/position [available]
                joint2/position [available]
                tcp_fts_sensor/force.x [available]
                tcp_fts_sensor/torque.z [available]

@codecov-commenter
Copy link

Codecov Report

Merging #1004 (2412878) into master (925f5f3) will decrease coverage by 1.93%.
The diff coverage is 35.61%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master    #1004      +/-   ##
==========================================
- Coverage   34.61%   32.69%   -1.93%     
==========================================
  Files          52       91      +39     
  Lines        2981     9551    +6570     
  Branches     1855     6432    +4577     
==========================================
+ Hits         1032     3123    +2091     
- Misses        310      704     +394     
- Partials     1639     5724    +4085     
Flag Coverage Δ
unittests 32.69% <35.61%> (-1.93%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
controller_manager/src/controller_manager.cpp 38.27% <ø> (-1.44%) ⬇️
controller_manager/src/ros2_control_node.cpp 0.00% <0.00%> (ø)
..._interface/include/hardware_interface/actuator.hpp 100.00% <ø> (ø)
...re_interface/include/hardware_interface/sensor.hpp 100.00% <ø> (ø)
...re_interface/include/hardware_interface/system.hpp 100.00% <ø> (ø)
hardware_interface/src/resource_manager.cpp 49.91% <ø> (-3.72%) ⬇️
hardware_interface/src/sensor.cpp 50.52% <ø> (ø)
hardware_interface/src/system.cpp 55.45% <ø> (ø)
...rface/test/mock_components/test_generic_system.cpp 9.14% <ø> (ø)
...dware_interface/test/test_component_interfaces.cpp 32.44% <ø> (+4.25%) ⬆️
... and 68 more

... and 19 files with indirect coverage changes

Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant, thanks :D

@bmagyar bmagyar merged commit e376c0b into ros-controls:master Apr 29, 2023
1 check passed
@bmagyar
Copy link
Member

bmagyar commented Apr 29, 2023

@Mergifyio backport humble

@mergify
Copy link
Contributor

mergify bot commented Apr 29, 2023

backport humble

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Apr 29, 2023
(cherry picked from commit e376c0b)

# Conflicts:
#	ros2controlcli/ros2controlcli/verb/list_hardware_components.py
@christophfroehlich christophfroehlich deleted the fix_cli branch April 29, 2023 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ros2controlcli list_hardware_components lists command ifs instead of state ifs
3 participants