Do not explode with empty tag

bmagyar · web-flow · commit 2f9a5549d71c · 2023-05-03T19:04:22.000+01:00
diff --git a/hardware_interface/src/component_parser.cpp b/hardware_interface/src/component_parser.cpp
@@ -14,6 +14,7 @@
 
 #include <tinyxml2.h>
 #include <charconv>
+#include <iostream>
 #include <regex>
 #include <stdexcept>
 #include <string>
@@ -68,7 +69,8 @@ std::string get_text_for_element(
   const auto get_text_output = element_it->GetText();
   if (!get_text_output)
   {
-    throw std::runtime_error("text not specified in the " + tag_name + " tag");
+    std::cerr << "text not specified in the " << tag_name << " tag" << std::endl;
+    return "";
   }
   return get_text_output;
 }

Original file line number	Diff line number	Diff line change
`@@ -14,6 +14,7 @@`
`14`	`14`
`15`	`15`	`#include <tinyxml2.h>`
`16`	`16`	`#include <charconv>`
	`17`	`+#include <iostream>`
`17`	`18`	`#include <regex>`
`18`	`19`	`#include <stdexcept>`
`19`	`20`	`#include <string>`
`@@ -68,7 +69,8 @@ std::string get_text_for_element(`
`68`	`69`	`const auto get_text_output = element_it->GetText();`
`69`	`70`	`if (!get_text_output)`
`70`	`71`	`{`
`71`		`- throw std::runtime_error("text not specified in the " + tag_name + " tag");`
	`72`	`+ std::cerr << "text not specified in the " << tag_name << " tag" << std::endl;`
	`73`	`+ return "";`
`72`	`74`	`}`
`73`	`75`	`return get_text_output;`
`74`	`76`	`}`