Update tests to allow empty URDF parameter to hardware interface

fmauch · fmauch · commit 2f33675d01a4 · 2023-05-11T14:55:31.000+02:00
diff --git a/hardware_interface/test/test_component_parser.cpp b/hardware_interface/test/test_component_parser.cpp
@@ -100,14 +100,14 @@ TEST_F(TestComponentParser, component_interface_type_empty_throws_error)
   ASSERT_THROW(parse_control_resources_from_urdf(broken_urdf_string), std::runtime_error);
 }
 
-TEST_F(TestComponentParser, parameter_empty_throws_error)
+TEST_F(TestComponentParser, parameter_empty_throws_no_error)
 {
   const std::string broken_urdf_string =
     std::string(ros2_control_test_assets::urdf_head) +
     ros2_control_test_assets::invalid_urdf_ros2_control_parameter_empty +
     ros2_control_test_assets::urdf_tail;
 
-  ASSERT_THROW(parse_control_resources_from_urdf(broken_urdf_string), std::runtime_error);
+  ASSERT_NO_THROW(parse_control_resources_from_urdf(broken_urdf_string));
 }
 
 TEST_F(TestComponentParser, successfully_parse_valid_urdf_system_one_interface)

Original file line number	Diff line number	Diff line change
`@@ -100,14 +100,14 @@ TEST_F(TestComponentParser, component_interface_type_empty_throws_error)`
`100`	`100`	`ASSERT_THROW(parse_control_resources_from_urdf(broken_urdf_string), std::runtime_error);`
`101`	`101`	`}`
`102`	`102`
`103`		`-TEST_F(TestComponentParser, parameter_empty_throws_error)`
	`103`	`+TEST_F(TestComponentParser, parameter_empty_throws_no_error)`
`104`	`104`	`{`
`105`	`105`	`const std::string broken_urdf_string =`
`106`	`106`	`std::string(ros2_control_test_assets::urdf_head) +`
`107`	`107`	`ros2_control_test_assets::invalid_urdf_ros2_control_parameter_empty +`
`108`	`108`	`ros2_control_test_assets::urdf_tail;`
`109`	`109`
`110`		`- ASSERT_THROW(parse_control_resources_from_urdf(broken_urdf_string), std::runtime_error);`
	`110`	`+ ASSERT_NO_THROW(parse_control_resources_from_urdf(broken_urdf_string));`
`111`	`111`	`}`
`112`	`112`
`113`	`113`	`TEST_F(TestComponentParser, successfully_parse_valid_urdf_system_one_interface)`