BCM2712 PCIEx1 tweaks #6180
Merged
BCM2712 PCIEx1 tweaks #6180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
P33M
force-pushed
the
pciex1_compat
branch
3 times, most recently
from
731728f
to
df555f1
Compare
L1 sub-states require the connection of the CLKREQ# auxiliary signal which is a PCB-level decision, and also depends on the vagrancies of adapters/interposers/slots that may exist between the chip and the endpoint. If this parameter is present, and the RC driver sees an L1 substate capability in the endpoint, then the result is a broken link if CLKREQ# isn't end-to-end connected - regardless of the state of the L1.x enable bits in the RC. Board-specific methods (HAT+ overlay, board DTB) should define this property if required. Signed-off-by: Jonathan Bell <[email protected]>
Interop testing with the M.2 HAT has revealed that there are many quirky endpoint devices out there, so users should have a way of rapidly iterating to find which quirk is causing reliability issues. Signed-off-by: Jonathan Bell <[email protected]>
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
May 24, 2024
See: raspberrypi/linux#6180 kernel: drivers: staging: bcm2835-isp: Respect caller's stride value See: raspberrypi/linux#5960 kernel: drivers: pcie-brcmstb: add best-effort workaround for QoS bug on bcm2712 See: raspberrypi/linux#6183 kernel: ARM: dts: Fix camera sync parameters See: raspberrypi/linux#6184 kernel: Add association between DRM panels and backlight where defined See: raspberrypi/linux#6177
popcornmix
added a commit
to raspberrypi/rpi-firmware
that referenced
this pull request
May 24, 2024
See: raspberrypi/linux#6180 kernel: drivers: staging: bcm2835-isp: Respect caller's stride value See: raspberrypi/linux#5960 kernel: drivers: pcie-brcmstb: add best-effort workaround for QoS bug on bcm2712 See: raspberrypi/linux#6183 kernel: ARM: dts: Fix camera sync parameters See: raspberrypi/linux#6184 kernel: Add association between DRM panels and backlight where defined See: raspberrypi/linux#6177
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turning on L1ss by default is more trouble than it's worth, so don't do that.
The compatibility overlay should eventually get the existing pciex1_* dtparams folded in to it, but they've grown documentation arms and legs so can't be immediately deprecated.