Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use lux-styleguidist #984

Merged
merged 66 commits into from
Apr 1, 2024
Merged

Use lux-styleguidist #984

merged 66 commits into from
Apr 1, 2024

Conversation

christinach
Copy link
Member

@christinach christinach commented Dec 29, 2023

Update vue and vue dependencies to vue3

When starting rails server and running the application, the error that we see and try to fix is:

"default" is not exported by "node_modules/vue/dist/vue.runtime.esm-bundler.js", imported by "node_modules/lux-design-system/dist/lux-styleguidist.mjs".
  file: /apps_team/approvals/node_modules/lux-design-system/dist/lux-styleguidist.mjs:1:7
  1: import wr, { openBlock as yt, createElementBlock as Qt, createElementVNode as jt, toDisplayString as ln, createCommen...
            ^
  2: const Ft = (n, e) => {
  3:   const r = n.__vccOpts || n;
  error during build:
  RollupError: "default" is not exported by "node_modules/vue/dist/vue.runtime.esm-bundler.js", imported by "node_modules/lux-design-system/dist/lux-styleguidist.mjs".
      at error (file:///apps_team/approvals/node_modules/rollup/dist/es/shared/parseAst.js:337:30)
      at Module.error (file:///apps_team/approvals/node_modules/rollup/dist/es/shared/node-entry.js:12737:16)
      at Module.traceVariable (file:///apps_team/approvals/node_modules/rollup/dist/es/shared/node-entry.js:13178:29)

@christinach christinach force-pushed the lux-styleguidist branch 2 times, most recently from d092c3a to 8b92e34 Compare February 23, 2024 22:01
@@ -1,9 +1,9 @@
<% if supervisor_filter_urls.count > 0 %>
<input-select name="supervisor_filter" value="<%= current_supervisor_filter_label %>" onchange="location.href = this.children[0].value; //jump to link location on select"
<lux-input-select name="supervisor_filter" value="<%= current_supervisor_filter_label %>" onchange="location.href = this.children[0].value; //jump to link location on select"

Check warning

Code scanning / CodeQL

DOM text reinterpreted as HTML Medium

DOM text
is reinterpreted as HTML without escaping meta-characters.
christinach and others added 10 commits March 27, 2024 10:57
* Removed hard-coded styles

* Fixed missed merge conflict

---------

Co-authored-by: Ryan Laddusaw <[email protected]>
* Sending the escape key to close the autocomplete that was blocking buttons

* Changed escape to tab

---------

Co-authored-by: Ryan Laddusaw <[email protected]>
Fixes luxInputText border #1121
Fixes bug in autocompleteInput
Mark Absence workflow tests as pending

Co-authored-by: Jane Sandberg <[email protected]>
Co-authored-by: Kevin Reiss <[email protected]>
@christinach christinach marked this pull request as ready for review April 1, 2024 14:22
@christinach
Copy link
Member Author

@kevinreiss can you also check the branch on staging and confirm that we can merge?

Copy link
Member

@kevinreiss kevinreiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants