Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spike on Upgrading to Vue 3 #1396

Closed
2 tasks
tpendragon opened this issue Mar 26, 2024 · 1 comment · Fixed by #1408
Closed
2 tasks

Spike on Upgrading to Vue 3 #1396

tpendragon opened this issue Mar 26, 2024 · 1 comment · Fixed by #1408
Assignees
Labels
dls-work-cycle Tickets designated for the next work cycle (limit 16) On Deck Next issues marked by product owners for working on. spike

Comments

@tpendragon
Copy link
Contributor

tpendragon commented Mar 26, 2024

https://github.com/pulibrary/lux-styleguidist

Instructions

https://github.com/pulibrary/lux-styleguidist/blob/main/UpgradeInstructions.md

Approvals change for reference: pulibrary/approvals#984

Component migration instructions: https://github.com/pulibrary/lux-styleguidist?tab=readme-ov-file#copying-vue-2-components-from-lux

Spike Instructions

Try spending up to a day to do this and see where blockers appear and find what we don't know and if we can reasonably continue it right now. Document blockers that appear in this ticket so we can discuss them. Expect code generated from this to be disposable.

Step One

Read the upgrade instructions and follow them.

Parts

@tpendragon tpendragon added the On Deck Next issues marked by product owners for working on. label Mar 26, 2024
@tpendragon tpendragon added dls-work-cycle Tickets designated for the next work cycle (limit 16) spike labels Apr 2, 2024
@tpendragon tpendragon changed the title Update Lux to Vue3 Spike on Upgrading to Vue 3 Apr 3, 2024
@eliotjordan eliotjordan self-assigned this Apr 4, 2024
This was referenced Apr 9, 2024
@eliotjordan
Copy link
Member

eliotjordan commented Apr 10, 2024

Upgrade Issues:

  • There is no longer a "special-collections-footer"
  • Pulfalight uses exported scss files that are not available in this version of lux. They had to be copied over to get Vite to compile.
  • Some of the old scss variable names are no longer in lux.
  • There are some styling issues with alignment, icons, etc...
  • Needs thorough testing on staging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dls-work-cycle Tickets designated for the next work cycle (limit 16) On Deck Next issues marked by product owners for working on. spike
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants