Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update specs: ./spec/controllers/requests_controller_spec.rb #1021

Closed
christinach opened this issue Feb 26, 2024 · 1 comment
Closed

Update specs: ./spec/controllers/requests_controller_spec.rb #1021

christinach opened this issue Feb 26, 2024 · 1 comment
Assignees
@maxkadel

Comments

@christinach
Copy link
Member

Run

bundle exec rspec ./spec/controllers/requests_controller_spec.rb

Update the lux component name.
Make the test pass.

Checkout a new branch from PR#984

Open the PR against PR#984
@maxkadel maxkadel self-assigned this Feb 29, 2024
@maxkadel
Copy link
Contributor

All except for RequestsController GET #my_approval_requests runs reasonably fast are passing - this has always been a flaky test for me locally, but passes in CI. This is an overall performance issue, not a lux-styleguidist issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maxkadel maxkadel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@christinach @maxkadel