Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update to go1.22 to fix various network CVE #5682

Closed
wants to merge 4 commits into from

Conversation

donbowman
Copy link
Contributor

Specifically CVE-2024-24790

What problem does this PR solve?

go1.22.5 fixes CVE-2024-24790,
a critical issue in golang: net/netip: Unexpected behavior from Is methods for IPv4-mapped IPv6 addresses

What is changed and how does it work?

Update the various ci pins of 1.21.3 to 1.22.5

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.

NONE

Copy link
Contributor

ti-chi-bot bot commented Jul 15, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign qiffang for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@csuzhangxc
Copy link
Member

CI failed

@csuzhangxc
Copy link
Member

CI failed

I'm try to bump Golang to v1.22 in #5683

@csuzhangxc csuzhangxc mentioned this pull request Jul 16, 2024
10 tasks
@ti-chi-bot ti-chi-bot bot added size/XS and removed size/S labels Aug 21, 2024
@ti-chi-bot ti-chi-bot mentioned this pull request Sep 26, 2024
10 tasks
Copy link
Contributor

ti-chi-bot bot commented Sep 28, 2024

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@csuzhangxc
Copy link
Member

updated to go1.23 in #5683

@csuzhangxc csuzhangxc closed this Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants