Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump golang to v1.22 #5683

Open
wants to merge 22 commits into
base: master
Choose a base branch
from
Open

bump golang to v1.22 #5683

wants to merge 22 commits into from

Conversation

csuzhangxc
Copy link
Member

@csuzhangxc csuzhangxc commented Jul 16, 2024 •
edited
Loading

What problem does this PR solve?

ref #5682

  • Bump Golang to v1.22
  • Many updates to ensure CI can work well

What is changed and how does it work?

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 16, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from csuzhangxc, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot requested a review from shonge July 16, 2024 02:28
@ti-chi-bot ti-chi-bot bot added the size/XXL label Jul 16, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jul 16, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.51%. Comparing base (9ef26f8) to head (edb56e7).
Report is 15 commits behind head on master.

❗ Current head edb56e7 differs from pull request most recent head 34a9244

Please upload reports for the commit 34a9244 to get more accurate results.

❗ There is a different number of reports uploaded between BASE (9ef26f8) and HEAD (edb56e7). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (9ef26f8) HEAD (edb56e7)
unittest 1 0
Additional details and impacted files 
@@             Coverage Diff             @@
##           master    #5683       +/-   ##
===========================================
- Coverage   61.47%   23.51%   -37.96%     
===========================================
  Files         235      219       -16     
  Lines       30653    30495      -158     
===========================================
- Hits        18843     7171    -11672     
- Misses       9920    22313    +12393     
+ Partials     1890     1011      -879
Flag Coverage Δ
e2e 23.51% <ø> (?)
unittest ?

@csuzhangxc
Copy link
Member Author

/run-all-tests

@csuzhangxc
Copy link
Member Author

/run-pull-e2e-kind

1 similar comment
@csuzhangxc
Copy link
Member Author

/run-pull-e2e-kind

@csuzhangxc
Copy link
Member Author

/run-pull-e2e-kind

@csuzhangxc
Copy link
Member Author

/run-pull-e2e-kind

@csuzhangxc
Copy link
Member Author

/run-pull-e2e-kind

@csuzhangxc
Copy link
Member Author

/run-pull-e2e-kind

1 similar comment
@csuzhangxc
Copy link
Member Author

/run-pull-e2e-kind

@csuzhangxc csuzhangxc changed the title [WIP] bump golang to v1.22 bump golang to v1.22 Jul 16, 2024
@csuzhangxc csuzhangxc mentioned this pull request Jul 16, 2024
Open
10 tasks
@csuzhangxc
Copy link
Member Author

/run-pull-e2e-kind-basic

@csuzhangxc
Copy link
Member Author

/run-pull-e2e-kind-br

@csuzhangxc
Copy link
Member Author

/run-pull-e2e-kind

1 similar comment
@csuzhangxc
Copy link
Member Author

/run-pull-e2e-kind

@csuzhangxc
Copy link
Member Author

/run-pull-e2e-kind

2 similar comments
@csuzhangxc
Copy link
Member Author

/run-pull-e2e-kind

@csuzhangxc
Copy link
Member Author

/run-pull-e2e-kind

@csuzhangxc
Copy link
Member Author

/run-pull-e2e-kind

1 similar comment
@csuzhangxc
Copy link
Member Author

/run-pull-e2e-kind

@csuzhangxc
Copy link
Member Author

/run-pull-e2e-kind

@csuzhangxc
Copy link
Member Author

/run-pull-e2e-kind

@csuzhangxc
Copy link
Member Author

/run-pull-e2e-kind

@csuzhangxc
Copy link
Member Author

/run-pull-e2e-kind

csuzhangxc
csuzhangxc commented Jul 24, 2024
View reviewed changes
tests/dm.go
@@ -60,7 +60,7 @@ const (
// DMMySQLSvcStsName is the upstream MySQL svc/sts name for DM E2E tests.
DMMySQLSvcStsName = "dm-mysql"
// DMMySQLImage is the upstream MySQL container image for DM E2E tests.
DMMySQLImage = "mysql:5.7"
DMMySQLImage = "mysql:8.0"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in MySQL 5.7, Golang (v1.22) client will get "remote error: tls: handshake failure"

ref elastic/beats#40082 (comment)

tests/e2e/util/image/image.go
TiDBLatestPrev = "v6.0.0"
TiDBLatest = "v6.1.0"
TiDBLatestPrev = "v7.5.2"
TiDBLatest = "v8.1.0"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bump DM for

Error: [Lightning:Restore:ErrCreateSchema]create schema failed, table: dm_cluster_5265.``, stmt: restore database schema: run create schema job failed: Error 1273: Unsupported collation when new collation is enabled: 'utf8mb4_0900_ai_ci'

@csuzhangxc
Copy link
Member Author

/run-pull-e2e-kind

@csuzhangxc csuzhangxc mentioned this pull request Jul 24, 2024
Merged
10 tasks
@csuzhangxc
Copy link
Member Author

/run-all-tests

@csuzhangxc
Copy link
Member Author

/run-pull-e2e-kind-br

@csuzhangxc
Copy link
Member Author

/run-pull-e2e-kind-serial

@csuzhangxc
Copy link
Member Author

/run-pull-e2e-kind-tngm

@csuzhangxc
Copy link
Member Author

/run-pull-e2e-kind-br

@csuzhangxc csuzhangxc mentioned this pull request Jul 25, 2024
Merged
10 tasks
This was referenced Jul 25, 2024
Merged
Merged
@csuzhangxc csuzhangxc mentioned this pull request Jul 29, 2024
Open
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shonge shonge Awaiting requested review from shonge

Assignees
No one assigned
Labels
size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@csuzhangxc @codecov-commenter