Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump golang to v1.23 (#5683) #5753

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #5683

What problem does this PR solve?

ref #5682

  • Bump Golang to v1.23
  • Many updates to ensure CI can work well

What is changed and how does it work?

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


Copy link
Contributor

ti-chi-bot bot commented Sep 26, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign wizardxiao for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@csuzhangxc
Copy link
Member

/run-all-tests

@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-1.6@6320ae0). Learn more about missing BASE report.

Additional details and impacted files
@@              Coverage Diff               @@
##             release-1.6    #5753   +/-   ##
==============================================
  Coverage               ?   47.12%           
==============================================
  Files                  ?      219           
  Lines                  ?    30697           
  Branches               ?        0           
==============================================
  Hits                   ?    14466           
  Misses                 ?    14512           
  Partials               ?     1719           
Flag Coverage Δ
e2e 47.12% <0.00%> (?)

@csuzhangxc
Copy link
Member

/run-pull-e2e-kind-br

@csuzhangxc
Copy link
Member

/run-pull-e2e-kind-tikv-scale-simultaneously

@csuzhangxc
Copy link
Member

/run-pull-e2e-kind-basic

@csuzhangxc
Copy link
Member

/run-pull-e2e-kind-br

@csuzhangxc
Copy link
Member

/run-pull-e2e-kind-across-kubernetes

@csuzhangxc
Copy link
Member

/run-pull-e2e-kind-serial

@csuzhangxc
Copy link
Member

/run-pull-e2e-kind-across-kubernetes

2 similar comments
@csuzhangxc
Copy link
Member

/run-pull-e2e-kind-across-kubernetes

@csuzhangxc
Copy link
Member

/run-pull-e2e-kind-across-kubernetes

@csuzhangxc csuzhangxc merged commit aa67a48 into pingcap:release-1.6 Sep 27, 2024
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants