Extend tests to other branches #24
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Draft
11 tasks
|
No idea why |
DanInci
reviewed
May 8, 2025
Comment on lines
+84
to
+95
| - name: Run benchmark | ||
| shell: bash -l {0} | ||
| run: | | ||
| env | ||
| output=$( ob run benchmark -b Clustering.yaml --local --threads 10 2>&1 ) | ||
| status=$? | ||
| if echo "$output" | grep -i 'Benchmark run has finished successfully'; then | ||
| status=0 | ||
| fi | ||
| echo -e $output | ||
| sh -c "exit $status" | ||
| if: matrix.ob_branch == 'main' |
Comment on lines
+76
to
+87
| - name: Run benchmark | ||
| shell: bash -l {0} | ||
| run: | | ||
| env | ||
| output=$( ob run benchmark -b Clustering.yaml --local --threads 10 2>&1 ) | ||
| status=$? | ||
| if echo "$output" | grep -i 'Benchmark run has finished successfully'; then | ||
| status=0 | ||
| fi | ||
| echo -e $output | ||
| sh -c "exit $status" | ||
| if: matrix.ob_branch == 'main' |
There was a problem hiding this comment.
For now, we would need to make sure to use a benchmark yaml without metric collectors for the main branch.
Or comment the main branch from the matrix.
Keeping it as it is, will just pollute the fail tests with false positive.
There was a problem hiding this comment.
I understand, but to me these are true positives, clustbench doesn't work on ob main. I'm looking forward to see all tests green, once ob main gets updated to be clustbench compatible. Different perspective I think.
There was a problem hiding this comment.
@imallona right, fair enough. We want to provide the nightly tests for all the expected features.
DanInci
approved these changes
May 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please squash on merge.
This nightly runs
clustbenchon conda using a variety of conda providers and on three differentobbranches:main,devand a custom one.The fact
mainfails to install is a feature of the action, not a bug. (It's trying to run clustbench with metric collectors on a version without metric collectors.)