-
Notifications
You must be signed in to change notification settings - Fork 1
Extend tests to other branches #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
0c212bf
Test my dev and normal dev separately; do not write pages
imallona 4a54dfb
Switch to matrix encoding
imallona 3c461fd
remove cached env
imallona 3082f74
Switch to self-hosted; not sure why failures are reported green
imallona a156236
Expect main to fail because of the metric collectors
imallona a579c2a
Add concurrency rules
imallona 026e0c6
Trigger
imallona 35daa61
To address the damn S3 storage not available. You might want to insta…
imallona e87e11e
Print stderr/stdout
imallona 0a22d34
dev works with mambaforge; grep outputs better
imallona ee4c1ef
Is it installing the requested micromamba version?
imallona 84d4566
On concurrency again
imallona 68a1c4b
Add nightly schedule
imallona 61b4125
Bring back the pages-generating action
imallona 164432c
Switch schedules to every 30 min
imallona 9188c90
Daily only
imallona File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,130 @@ | ||
name: micromamba | ||
# concurrency: | ||
# group: ${{ github.head_ref || github.run_id }} | ||
# cancel-in-progress: true | ||
|
||
on: | ||
pull_request: | ||
workflow_dispatch: | ||
schedule: | ||
# - cron: "*/30 * * * *" # Runs every 30 minutes for testing | ||
- cron: "30 1 * * *" # at 1.30am | ||
## these permissions are only for deployment to gh pages | ||
# permissions: | ||
# id-token: write | ||
# pages: write | ||
|
||
jobs: | ||
run-benchmark-micromamba: | ||
name: run_clustbench_micromamba | ||
## runs-on: ubuntu-latest | ||
runs-on: self-hosted | ||
strategy: | ||
matrix: | ||
ob_branch: [dev, reduce_install_scope, main] | ||
micromamba-version: ['2.1.1-0', '2.0.5-0', '1.5.12-0', '1.5.8-0'] | ||
fail-fast: false | ||
concurrency: | ||
group: micromamba-${{ matrix.micromamba-version }}-${{ matrix.ob_branch }} | ||
cancel-in-progress: false # true | ||
steps: | ||
- name: Check out repository | ||
uses: actions/checkout@v4 | ||
|
||
- name: Install (with) micromamba | ||
uses: mamba-org/setup-micromamba@v2 | ||
with: | ||
cache-environment: false # true | ||
micromamba-version: ${{ matrix.micromamba-version }} | ||
download-micromamba: true | ||
micromamba-binary-path: ${{ runner.temp }}/bin/micromamba-${{ matrix.micromamba-version }}/micromamba | ||
environment-name: test-env-${{matrix.ob_branch }}-${{ matrix.micromamba-version }} | ||
create-args: >- | ||
python=3.12 | ||
pip | ||
conda | ||
post-cleanup: environment # all | ||
- name: Overwrite omnibenchmark CLI to branch | ||
shell: bash -l {0} | ||
run: | | ||
micromamba --version | ||
pip install git+https://github.com/omnibenchmark/omnibenchmark.git@${{ matrix.ob_branch }} | ||
|
||
# - name: Enable a benchmarking `out` cache | ||
# id: cache-benchmark | ||
# uses: actions/cache@v3 | ||
# with: | ||
# path: out/ | ||
# key: benchmark-${{ runner.os }}-${{ hashFiles('Clustering.yaml') }} | ||
|
||
- name: Run benchmark | ||
shell: bash -l {0} | ||
run: | | ||
env | ||
output=$( echo "y" | ob run benchmark -b Clustering.yaml --local --cores 10 2>&1 ) | ||
status=$? | ||
if echo "$output" | grep -i 'Benchmark run has finished successfully'; then | ||
status=0 | ||
fi | ||
echo -e $output | ||
sh -c "exit $status" | ||
if: matrix.ob_branch == 'dev' || matrix.ob_branch == 'reduce_install_scope' | ||
|
||
- name: Run benchmark | ||
shell: bash -l {0} | ||
run: | | ||
env | ||
output=$( ob run benchmark -b Clustering.yaml --local --threads 10 2>&1 ) | ||
status=$? | ||
if echo "$output" | grep -i 'Benchmark run has finished successfully'; then | ||
status=0 | ||
fi | ||
echo -e $output | ||
sh -c "exit $status" | ||
if: matrix.ob_branch == 'main' | ||
|
||
# upload-artifact: | ||
# name: Benchmark Artifact | ||
# runs-on: ubuntu-latest | ||
# ## runs-on: self-hosted | ||
# needs: run-benchmark | ||
# if: always() | ||
# steps: | ||
# - name: Check out repository | ||
# uses: actions/checkout@v4 | ||
|
||
# - name: Load cached output | ||
# uses: actions/cache@v3 | ||
# with: | ||
# path: out/ | ||
# key: benchmark-${{ runner.os }}-${{ hashFiles('Clustering.yaml') }} | ||
|
||
# - name: Prepare output | ||
# run: | | ||
# zip -r benchmark_output.zip out/ | ||
# mkdir -p gh-pages | ||
# cp out/plotting/plotting_report.html gh-pages/index.html | ||
|
||
# - name: Upload zipped output | ||
# uses: actions/upload-artifact@v4 | ||
# with: | ||
# name: benchmark-output | ||
# path: benchmark_output.zip | ||
# retention-days: 7 | ||
|
||
# - name: Upload Pages Artifact | ||
# uses: actions/upload-pages-artifact@v3 | ||
# with: | ||
# path: gh-pages | ||
|
||
# - name: Deploy to GitHub Pages | ||
# uses: actions/deploy-pages@v4 | ||
|
||
# - name: Create Job Summary | ||
# if: always() | ||
# run: | | ||
# echo "### Reports" >> $GITHUB_STEP_SUMMARY | ||
# echo "- [Plotting Report](https://${{ github.repository_owner }}.github.io/${{ github.event.repository.name }})" >> $GITHUB_STEP_SUMMARY | ||
# echo "### All Outputs" >> $GITHUB_STEP_SUMMARY | ||
# echo "- [Complete Benchmark Output](https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}#artifacts)" >> $GITHUB_STEP_SUMMARY | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,139 @@ | ||
name: clustbench_miniforge | ||
# concurrency: | ||
# group: ${{ github.head_ref || github.run_id }} | ||
# cancel-in-progress: true | ||
|
||
on: | ||
pull_request: | ||
workflow_dispatch: | ||
schedule: | ||
# - cron: "*/30 * * * *" # Runs every 30 minutes for testing | ||
- cron: "30 1 * * *" # at 1.30am | ||
|
||
## these permissions are only for deployment to gh pages | ||
# permissions: | ||
# id-token: write | ||
# pages: write | ||
|
||
jobs: | ||
run-benchmark-miniforge: | ||
name: run_clustbench_miniforge | ||
## runs-on: ubuntu-latest | ||
runs-on: self-hosted | ||
strategy: | ||
matrix: | ||
ob_branch: [dev, reduce_install_scope, main] | ||
fail-fast: false | ||
concurrency: | ||
group: mambaforge-${{ matrix.ob_branch }} | ||
cancel-in-progress: false # true | ||
steps: | ||
- name: Check out repository | ||
uses: actions/checkout@v4 | ||
|
||
- name: Install Mambaforge | ||
uses: conda-incubator/setup-miniconda@v3 | ||
with: | ||
miniforge-variant: Miniforge3 | ||
use-mamba: true | ||
activate-environment: test-env-${{matrix.ob_branch }} | ||
python-version: "3.12" | ||
auto-update-conda: true | ||
channels: conda-forge | ||
|
||
- name: Cache environment | ||
id: cache-env | ||
uses: actions/cache@v3 | ||
with: | ||
path: | | ||
~/.conda/pkgs | ||
~/.conda/envs/omnibenchmark-env | ||
~/.cache/pip | ||
key: ${{ runner.os }}-conda-pip-${{ hashFiles('requirements.txt') }} | ||
restore-keys: | | ||
${{ runner.os }}-conda-pip- | ||
|
||
- name: Install omnibenchmark CLI | ||
shell: bash -l {0} | ||
run: | | ||
mamba install -y pip | ||
pip install git+https://github.com/omnibenchmark/omnibenchmark.git@${{ matrix.ob_branch }} | ||
|
||
# - name: Enable a benchmarking `out` cache | ||
# id: cache-benchmark | ||
# uses: actions/cache@v3 | ||
# with: | ||
# path: out/ | ||
# key: benchmark-${{ runner.os }}-${{ hashFiles('Clustering.yaml') }} | ||
|
||
- name: Run benchmark | ||
shell: bash -l {0} | ||
run: | | ||
env | ||
output=$( echo "y" | ob run benchmark -b Clustering.yaml --local --cores 10 2>&1 ) | ||
status=$? | ||
if echo "$output" | grep -i 'Benchmark run has finished successfully'; then | ||
status=0 | ||
fi | ||
echo -e $output | ||
sh -c "exit $status" | ||
if: matrix.ob_branch == 'dev' || matrix.ob_branch == 'reduce_install_scope' | ||
|
||
- name: Run benchmark | ||
shell: bash -l {0} | ||
run: | | ||
env | ||
output=$( ob run benchmark -b Clustering.yaml --local --threads 10 2>&1 ) | ||
status=$? | ||
if echo "$output" | grep -i 'Benchmark run has finished successfully'; then | ||
status=0 | ||
fi | ||
echo -e $output | ||
sh -c "exit $status" | ||
if: matrix.ob_branch == 'main' | ||
Comment on lines
+82
to
+93
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same reasoning here. |
||
|
||
# upload-artifact: | ||
# name: Benchmark Artifact | ||
# runs-on: ubuntu-latest | ||
# ## runs-on: self-hosted | ||
# needs: run-benchmark | ||
# if: always() | ||
# steps: | ||
# - name: Check out repository | ||
# uses: actions/checkout@v4 | ||
|
||
# - name: Load cached output | ||
# uses: actions/cache@v3 | ||
# with: | ||
# path: out/ | ||
# key: benchmark-${{ runner.os }}-${{ hashFiles('Clustering.yaml') }} | ||
|
||
# - name: Prepare output | ||
# run: | | ||
# zip -r benchmark_output.zip out/ | ||
# mkdir -p gh-pages | ||
# cp out/plotting/plotting_report.html gh-pages/index.html | ||
|
||
# - name: Upload zipped output | ||
# uses: actions/upload-artifact@v4 | ||
# with: | ||
# name: benchmark-output | ||
# path: benchmark_output.zip | ||
# retention-days: 7 | ||
|
||
# - name: Upload Pages Artifact | ||
# uses: actions/upload-pages-artifact@v3 | ||
# with: | ||
# path: gh-pages | ||
|
||
# - name: Deploy to GitHub Pages | ||
# uses: actions/deploy-pages@v4 | ||
|
||
# - name: Create Job Summary | ||
# if: always() | ||
# run: | | ||
# echo "### Reports" >> $GITHUB_STEP_SUMMARY | ||
# echo "- [Plotting Report](https://${{ github.repository_owner }}.github.io/${{ github.event.repository.name }})" >> $GITHUB_STEP_SUMMARY | ||
# echo "### All Outputs" >> $GITHUB_STEP_SUMMARY | ||
# echo "- [Complete Benchmark Output](https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}#artifacts)" >> $GITHUB_STEP_SUMMARY | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now, we would need to make sure to use a benchmark yaml without metric collectors for the main branch.
Or comment the main branch from the matrix.
Keeping it as it is, will just pollute the fail tests with false positive.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand, but to me these are true positives, clustbench doesn't work on ob main. I'm looking forward to see all tests green, once ob main gets updated to be clustbench compatible. Different perspective I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@imallona right, fair enough. We want to provide the nightly tests for all the expected features.