[RHELC-1169] Add a log message to check if the user has a back up of their system #1235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1235 +/- ##
=======================================
Coverage 96.59% 96.59%
=======================================
Files 71 71
Lines 5113 5117 +4
Branches 883 883
=======================================
+ Hits 4939 4943 +4
Misses 98 98
Partials 76 76
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
r0x0d
reviewed
May 21, 2024
Andrew-ang9
force-pushed
the
confirm_system_backup
branch
from
87cd8ea
to
cca495a
Compare
Andrew-ang9
force-pushed
the
confirm_system_backup
branch
from
1d4b48d
to
70927c6
Compare
Andrew-ang9
changed the title
Andrew-ang9
force-pushed
the
confirm_system_backup
branch
from
70927c6
to
fac623d
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
r0x0d
reviewed
Jun 24, 2024
r0x0d
reviewed
Jun 24, 2024
r0x0d
reviewed
Jun 26, 2024
r0x0d
reviewed
Jun 26, 2024
r0x0d
reviewed
Jun 26, 2024
r0x0d
reviewed
Jun 26, 2024
There was a problem hiding this comment.
Looks good now. @Venefilyn regarding the ask to continue, should we have just 1 at that perform_boilerplate function, or we keep with two?
We will ask to continue after the data collection message, and with the addition from @Andrew-ang9, we will have a second one after that to confirm the backup.
What do you think?
|
Also, @Andrew-ang9, I think you have linked the wrong jira issue in this PR. |
Andrew-ang9
force-pushed
the
confirm_system_backup
branch
from
9018d54
to
c2f1e8a
Compare
Andrew-ang9
changed the title
Andrew-ang9
changed the title
Andrew-ang9
changed the title
Andrew-ang9
force-pushed
the
confirm_system_backup
branch
2 times, most recently
from
8a400ca
to
781fb31
Compare
Andrew-ang9
force-pushed
the
confirm_system_backup
branch
2 times, most recently
from
28665c4
to
9ee6204
Compare
* In the intergration tests there where two more tests that needed the extra input value "y" so that it would account for the new prompt
* there are a few more intergration tests that needed another input for the new check that was added
* added the extra propmts in test_basic_sanity_checks.py and test_assessment_report.py
* There was an extra c2r.expect line in the pre_registered_systems_conversions intergration test
* Added the input for the intergration test pre_registered_system_conversion
Andrew-ang9
force-pushed
the
confirm_system_backup
branch
from
d0a0e8d
to
308feb0
Compare
* in the last commit it just changed the test but it was supposed to remove the test all together it is now fully removed
for more information, see https://pre-commit.ci
|
/packit test --labels tier0 |
|
/packit test --labels tier0 |
* This is just a test to try and see whats going on with the test Just to make sure that this test needs two prompts
|
/packit test --labels tier0 |
kokesak
reviewed
Oct 23, 2024
tests/integration/tier0/destructive/conversion-method/test_pre_registered.py
Outdated
Show resolved
Hide resolved
kokesak
reviewed
Oct 23, 2024
tests/integration/tier0/non-destructive/custom-repository/test_custom_repository.py
Outdated
Show resolved
Hide resolved
|
/packit test --labels tier0 |
|
This should be hopefully last test that still needs fixing - https://github.com/oamg/convert2rhel/blob/main/tests/integration/tier0/non-destructive/system-release-backup/test_system_release_backup.py#L90. |
|
/packit test --labels tier0 |
kokesak
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add this log message into the analysis because the system could not roll back completely. So we should warn the user.
Jira Issues:
Checklist
[RHELC-]is part of the PR titleRelease Pendingif relevant