-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RHELC-1169] Add a log message to check if the user has a back up of their system #1235
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1235 +/- ##
=======================================
Coverage 96.59% 96.59%
=======================================
Files 71 71
Lines 5113 5117 +4
Branches 883 883
=======================================
+ Hits 4939 4943 +4
Misses 98 98
Partials 76 76
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
87cd8ea
to
cca495a
Compare
1d4b48d
to
70927c6
Compare
70927c6
to
fac623d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now. @Venefilyn regarding the ask to continue, should we have just 1 at that perform_boilerplate function, or we keep with two?
We will ask to continue after the data collection message, and with the addition from @Andrew-ang9, we will have a second one after that to confirm the backup.
What do you think?
Also, @Andrew-ang9, I think you have linked the wrong jira issue in this PR. |
9018d54
to
c2f1e8a
Compare
8a400ca
to
781fb31
Compare
28665c4
to
9ee6204
Compare
* In the intergration tests there where two more tests that needed the extra input value "y" so that it would account for the new prompt
* there are a few more intergration tests that needed another input for the new check that was added
* added the extra propmts in test_basic_sanity_checks.py and test_assessment_report.py
* There was an extra c2r.expect line in the pre_registered_systems_conversions intergration test
* Added the input for the intergration test pre_registered_system_conversion
d0a0e8d
to
308feb0
Compare
* in the last commit it just changed the test but it was supposed to remove the test all together it is now fully removed
for more information, see https://pre-commit.ci
/packit test --labels tier0 |
/packit test --labels tier0 |
* This is just a test to try and see whats going on with the test Just to make sure that this test needs two prompts
/packit test --labels tier0 |
tests/integration/tier0/destructive/conversion-method/test_pre_registered.py
Outdated
Show resolved
Hide resolved
tests/integration/tier0/non-destructive/custom-repository/test_custom_repository.py
Outdated
Show resolved
Hide resolved
/packit test --labels tier0 |
This should be hopefully last test that still needs fixing - https://github.com/oamg/convert2rhel/blob/main/tests/integration/tier0/non-destructive/system-release-backup/test_system_release_backup.py#L90. |
/packit test --labels tier0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from my side. The remaining failing tests are expected to fail now.
Add this log message into the analysis because the system could not roll back completely. So we should warn the user.
Jira Issues:
Checklist
[RHELC-]
is part of the PR titleRelease Pending
if relevant