Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHELC-1169] Add a log message to check if the user has a back up of their system #1235

Merged
merged 29 commits into from
Oct 25, 2024

Commits on Oct 18, 2024

  1. Added the log message for the user system backup

    * This commit adds to the print_data_collection()
      to make sure the user knows to back up there system
      before running convert2rhel analyze
    Andrew-ang9 committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    c98f96e View commit details
    Browse the repository at this point in the history
  2. Moved the log outside the print_data_collection()

    * it is better to have this outside of the print_data_collection()
      as it has nothing to do with that
    Andrew-ang9 committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    7239776 View commit details
    Browse the repository at this point in the history
  3. Moved the confirmation of user backup

    * the confirmation for the users backup is now its own function
      and is seperated from the print_data_collection() as this has noting
      to do with that function
    * Added the call to the new function to be right after the
      print_data_collection()
    Andrew-ang9 committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    fc4c425 View commit details
    Browse the repository at this point in the history
  4. Made a function for the user back up check

    * now the prompt to ask the user if they have a back up of there system
      is in a function
    * draft the unit test for this function
    Andrew-ang9 committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    04a92e5 View commit details
    Browse the repository at this point in the history
  5. Moved the confirm_user_backup() to main.py

    *Moved the function and test to main.py, and main_test.py as this check doesn't align with
      what breadcrumbs.py is doing
    Andrew-ang9 committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    8722fdb View commit details
    Browse the repository at this point in the history
  6. Finnished the uint test for Confirm_user_backup()

    * This unit test was mostly done we just needed to account for the
      user input and now it does that and it passes
    Andrew-ang9 committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    ea55420 View commit details
    Browse the repository at this point in the history
  7. Removed leftover imports from breadcrumbs_test.py

    * In the test for breadcrumbs_test.py there where imports for the
      test that were never used
    * fixed two tests that fail with the addition of this test because
      the function calls utils.ask_to_continue() more then the other
      tests expect
    Andrew-ang9 committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    2fde33a View commit details
    Browse the repository at this point in the history
  8. Draft used the mock for the users input

    * This commit changes the way the unit test is set up so that it
      now uses the ask_to_continue_mock in main_test to mock user input
    * Removed the import for unit test as the old test used it
    * Reverted the other uint tests that used the ask_to_continue_mock
      fuctions and set their values back to what they were before
      modification in the first commit
    Andrew-ang9 committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    ad0f23d View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    b5cc721 View commit details
    Browse the repository at this point in the history
  10. Added a mock to ask_to_continue() in

    * in some of the other tests the ask_to_continue fuction is now
      being called from the test_confirm_user_backup() and this should
      be handled so for thoes functions a mock,monkeypatch, and a check
      was added. functions:test_main_rollback_analyze_exit_phase,
      test_main_rollback_analyze_exit_phase_without_subman,
      test_main_rollback_pre_ponr_changes_phase,
      test_main_traceback_before_action_completion,
      test_main_traceback_in_clear_versionlock,
    Andrew-ang9 committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    105c536 View commit details
    Browse the repository at this point in the history
  11. Draft for the fix for the sanity tests

    * the intergration tests needed another yes input for the newly added
      prompt
    Andrew-ang9 committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    472b4de View commit details
    Browse the repository at this point in the history
  12. Draft added in the rest of the fixes for the tests

    * In the intergration tests there where two more tests that needed
      the extra input value "y" so that it would account for the new
      prompt
    Andrew-ang9 committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    886547b View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    e18da44 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    f60d80f View commit details
    Browse the repository at this point in the history
  15. Added in some more cases for the intergration test

    * there are a few more intergration tests that needed another input
      for the new check that was added
    Andrew-ang9 committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    e0abaa3 View commit details
    Browse the repository at this point in the history
  16. added in two yes prompts for the intergartion test

    * added the extra propmts in test_basic_sanity_checks.py
      and test_assessment_report.py
    Andrew-ang9 committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    9c74bb7 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    3b08ad9 View commit details
    Browse the repository at this point in the history
  18. Removed one of the c2r.expect lines from a test

    * There was an extra c2r.expect line in the
      pre_registered_systems_conversions intergration test
    Andrew-ang9 committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    6607a58 View commit details
    Browse the repository at this point in the history
  19. Added a prompt to another intergration test

    * Added the input for the intergration test pre_registered_system_conversion
    Andrew-ang9 committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    011bdc0 View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    308feb0 View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    a37bb0c View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    39138a4 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2024

  1. Removed some old code from a rebase

    Anderw Anglin committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    4293d95 View commit details
    Browse the repository at this point in the history
  2. fully removed the test_confirm_user_backup() from breadcrumbs_test

    * in the last commit it just changed the test but it was supposed to
      remove the test all together it is now fully removed
    Anderw Anglin committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    6f74781 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b9e4db7 View commit details
    Browse the repository at this point in the history
  4. Draft trying to just pass the input for the test

    Anderw Anglin committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    42a484d View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2024

  1. draft Commited out the extra prompt

    * This is just a test to try and see whats going on with the test
      Just to make sure that this test needs two prompts
    Andrew-ang9 committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    ed1ccd2 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2024

  1. Configuration menu
    Copy the full SHA
    b5860a6 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2024

  1. draft added in a prompt

    Andrew-ang9 committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    fe6fc06 View commit details
    Browse the repository at this point in the history