Skip to content

Commit

Permalink
Removed leftover imports from breadcrumbs_test.py
Browse files Browse the repository at this point in the history
* In the test for breadcrumbs_test.py there where imports for the
  test that were never used
* fixed two tests that fail with the addition of this test because
  the function calls utils.ask_to_continue() more then the other
  tests expect
  • Loading branch information
Andrew-ang9 committed Jul 8, 2024
1 parent c322cd9 commit 781fb31
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 6 deletions.
4 changes: 0 additions & 4 deletions convert2rhel/unit_tests/breadcrumbs_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,17 +18,13 @@
__metaclass__ = type

import json
import sys

import pytest
import six

import convert2rhel.toolopts

from convert2rhel import breadcrumbs, pkghandler, pkgmanager
from convert2rhel.unit_tests import create_pkg_information, create_pkg_obj
from convert2rhel.unit_tests.conftest import centos7
from convert2rhel.unit_tests.toolopts_test import mock_cli_arguments


six.add_move(six.MovedModule("mock", "mock", "unittest.mock"))
Expand Down
4 changes: 2 additions & 2 deletions convert2rhel/unit_tests/main_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,7 @@ def test_main(monkeypatch, tmp_path):
assert raise_for_skipped_failures_mock.call_count == 2
assert report_summary_mock.call_count == 2
assert clear_versionlock_mock.call_count == 1
assert ask_to_continue_mock.call_count == 1
assert ask_to_continue_mock.call_count == 2
assert post_ponr_conversion_mock.call_count == 1
assert rpm_files_diff_mock.call_count == 1
assert remove_tmp_dir_mock.call_count == 1
Expand Down Expand Up @@ -700,7 +700,7 @@ def test_main_rollback_post_ponr_changes_phase(self, monkeypatch, caplog, tmp_pa
assert find_actions_of_severity_mock.call_count == 1
assert clear_versionlock_mock.call_count == 1
assert report_summary_mock.call_count == 2
assert ask_to_continue_mock.call_count == 1
assert ask_to_continue_mock.call_count == 2
assert post_ponr_conversion_mock.call_count == 1
assert finish_collection_mock.call_count == 1
assert summary_as_json_mock.call_count == 1
Expand Down

0 comments on commit 781fb31

Please sign in to comment.