Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Digital Ocean references #2838

Merged
merged 6 commits into from
Nov 19, 2024
Merged

Remove Digital Ocean references #2838

merged 6 commits into from
Nov 19, 2024

Conversation

marcelovilla
Copy link
Member

@marcelovilla marcelovilla commented Nov 8, 2024 •
edited
Loading

Reference Issues or PRs

Closes #2749

Companion docs PR: nebari-dev/nebari-docs#544

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

How to test this PR?

Any other comments?

@marcelovilla marcelovilla mentioned this pull request Nov 8, 2024
Closed
@marcelovilla marcelovilla changed the title First sweep Remove Digital Ocean references Nov 8, 2024
@marcelovilla marcelovilla mentioned this pull request Nov 18, 2024
Open
18 tasks
@marcelovilla marcelovilla marked this pull request as ready for review November 18, 2024 10:27
dcmcand
dcmcand approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@dcmcand dcmcand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcelovilla marcelovilla merged commit b442200 into main Nov 19, 2024
28 checks passed
@marcelovilla marcelovilla deleted the remove-do branch November 19, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcmcand dcmcand dcmcand approved these changes

@Adam-D-Lewis Adam-D-Lewis Awaiting requested review from Adam-D-Lewis

@viniciusdc viniciusdc Awaiting requested review from viniciusdc

Assignees
No one assigned
Labels
None yet
Projects
🪴 Nebari Project Management
Status: Done 💪🏾
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove references to Digital Ocean in code base
2 participants
@marcelovilla @dcmcand