Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DigitalOcean references in the docs #544

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

marcelovilla
Copy link
Member

Reference Issues or PRs

This is a companion docs PR for nebari-dev/nebari#2838 and is related to issue nebari-dev/nebari#2749

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Documentation

Access-centered content checklist

Text styling

  • The content is written with plain language (where relevant).
  • If there are headers, they use the proper header tags (with only one level-one header: H1 or # in markdown).
  • All links describe where they link to (for example, check the Nebari website).
  • This content adheres to the Nebari style guides.

Non-text content

  • All content is represented as text (for example, images need alt text, and videos need captions or descriptive transcripts).
  • If there are emojis, there are not more than three in a row.
  • Don't use flashing GIFs or videos.
  • If the content were to be read as plain text, it still makes sense, and no information is missing.

Any other comments?

Copy link

netlify bot commented Nov 18, 2024

Deploy Preview for nebari-docs ready!

Name Link
🔨 Latest commit 9554d08
🔍 Latest deploy log https://app.netlify.com/sites/nebari-docs/deploys/673b87dfaf2b2500087cebe3
😎 Deploy Preview https://deploy-preview-544--nebari-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@marcelovilla marcelovilla marked this pull request as draft November 18, 2024 08:22
@marcelovilla
Copy link
Member Author

marcelovilla commented Nov 18, 2024

@marcelovilla marcelovilla marked this pull request as ready for review November 18, 2024 10:26
Copy link
Contributor

@dcmcand dcmcand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a missed reference on:

and

Currently, Nebari supports [Amazon AWS][nebari-aws], [DigitalOcean][nebari-do], [Google GCP][nebari-gcp], and [Azure][nebari-azure].

Also, I am guessing this would be in the release notes, but we should have a note explaining why digital ocean is gone.

@marcelovilla
Copy link
Member Author

@dcmcand thanks for the review and for catching those lingering references.

Also, I am guessing this would be in the release notes, but we should have a note explaining why digital ocean is gone.

Correct. I think we should add a note to the release notes explaining this and adding an alternative for users that might still want to use Nebari in DigitalOcean (i.e., using the existing option)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo 📬
Development

Successfully merging this pull request may close these issues.

2 participants