Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to Digital Ocean in code base #2749

Closed
Adam-D-Lewis opened this issue Sep 30, 2024 · 4 comments · Fixed by #2838
Closed

Remove references to Digital Ocean in code base #2749

Adam-D-Lewis opened this issue Sep 30, 2024 · 4 comments · Fixed by #2838

Comments

@Adam-D-Lewis
Copy link
Member

Context

Digital Ocean has been deprecated for several releases now with a warning. No one has protested this change. We should remove Digital Ocean functionality from the code base now.

Related RFD - nebari-dev/governance#50

Value and/or benefit

Less maintenance, Focus on other improvments

Anything else?

No response

@Adam-D-Lewis Adam-D-Lewis added the needs: triage 🚦 Someone needs to have a look at this issue and triage label Sep 30, 2024
@Adam-D-Lewis Adam-D-Lewis added this to the Next Release milestone Sep 30, 2024
@Adam-D-Lewis Adam-D-Lewis added provider: Digital Ocean and removed needs: triage 🚦 Someone needs to have a look at this issue and triage labels Sep 30, 2024
@viniciusdc
Copy link
Contributor

@marcelovilla
Copy link
Member

  • Remove digital ocean from unit tests parameters

Seems this is being taken care of in #2813

@Adam-D-Lewis
Copy link
Member Author

Adam-D-Lewis commented Nov 5, 2024

Seems this is being taken care of in #2813

That PR removes the tests, but not the many references to Digital Ocean in the code base (or the docs).

@marcelovilla
Copy link
Member

That PR removes the tests, but not the many references to Digital Ocean in the code base (or the docs).

Correct, I meant the reference in the tests.

I've opened #2838 to remove all the references. It's still a draft PR and it likely needs more work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done 💪🏾
Development

Successfully merging a pull request may close this issue.

3 participants