-
Notifications
You must be signed in to change notification settings - Fork 545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix MeshShape::clear() for safer mesh removal #3164
Conversation
Added a check to retrieve the mesh by name before attempting to remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3164 +/- ##
==========================================
- Coverage 44.44% 44.08% -0.35%
==========================================
Files 698 698
Lines 61558 61541 -17
Branches 7459 7459
==========================================
- Hits 27353 27124 -229
- Misses 34037 34248 +211
- Partials 168 169 +1 ☔ View full report in Codecov by Sentry. |
Added a check to retrieve the mesh by name before attempting to remove it. (cherry picked from commit f91a650)
Added a check to retrieve the mesh by name before attempting to remove it. (cherry picked from commit f91a650)
Co-authored-by: Matt Wang <[email protected]>
Co-authored-by: Matt Wang <[email protected]>
Description
To address #3162 (comment), I add a check to retrieve the mesh by name before attempting to remove it.
Checklist