Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MeshShape::clear() for safer mesh removal #3164

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

scmwang
Copy link
Contributor

@scmwang scmwang commented Dec 16, 2024

Description

To address #3162 (comment), I add a check to retrieve the mesh by name before attempting to remove it.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

Added a check to retrieve the mesh by name before attempting to remove it.
@sea-bass sea-bass added backport-humble Mergify label that triggers a PR backport to Humble backport-jazzy Mergify label that triggers a PR backport to Jazzy labels Dec 16, 2024
Copy link
Contributor

@sjahr sjahr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sjahr sjahr enabled auto-merge December 16, 2024 09:45
@sjahr sjahr added this pull request to the merge queue Dec 16, 2024
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 44.08%. Comparing base (abb440d) to head (55d41c2).

Files with missing lines Patch % Lines
...zation/rviz_plugin_render_tools/src/mesh_shape.cpp 0.00% 4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3164      +/-   ##
==========================================
- Coverage   44.44%   44.08%   -0.35%     
==========================================
  Files         698      698              
  Lines       61558    61541      -17     
  Branches     7459     7459              
==========================================
- Hits        27353    27124     -229     
- Misses      34037    34248     +211     
- Partials      168      169       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Merged via the queue into moveit:main with commit f91a650 Dec 16, 2024
9 checks passed
mergify bot pushed a commit that referenced this pull request Dec 16, 2024
Added a check to retrieve the mesh by name before attempting to remove it.

(cherry picked from commit f91a650)
mergify bot pushed a commit that referenced this pull request Dec 16, 2024
Added a check to retrieve the mesh by name before attempting to remove it.

(cherry picked from commit f91a650)
sea-bass pushed a commit that referenced this pull request Dec 16, 2024
sea-bass pushed a commit that referenced this pull request Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-humble Mergify label that triggers a PR backport to Humble backport-jazzy Mergify label that triggers a PR backport to Jazzy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RViz crashes when clicking "Reset" button while using the Planning Plugin
4 participants